fix(configure): add --platform filter to --from-browser (#446)#474
Open
nankingjing wants to merge 1 commit into
Open
fix(configure): add --platform filter to --from-browser (#446)#474nankingjing wants to merge 1 commit into
nankingjing wants to merge 1 commit into
Conversation
) agent-reach configure --from-browser chrome previously extracted cookies for ALL supported platforms in one pass, over-collecting and persisting full-domain cookie strings for platforms whose spec uses cookies: None (XHS/Xueqiu). Add --platform flag so users can limit extraction to a single platform: agent-reach configure --from-browser chrome --platform twitter The install path is unchanged (extracts all platforms). Includes tests for platform filter logic and unknown-platform error. Fixes Panniantong#446 Co-Authored-By: Claude <noreply@anthropic.com>
moxxxskaifa
approved these changes
Jul 5, 2026
moxxxskaifa
left a comment
moxxxskaifa
left a comment
There was a problem hiding this comment.
解决 #446（--from-browser 过量采集 cookie）：
- extract_all() 增加 platform 参数 ✅
- 筛选只在 python 层面做，不影响底层的 rookiepy/cookie3 ✅
63 行安全的新功能。 LGTM!
Author
|
您好 @moxxxskaifa，这个 PR 已经 approved，是否可以合并了？谢谢！ |
Author
|
Hi @moxxxskaifa, this PR has been approved — could you merge it when you have a moment? Thanks! |
Author
|
您好 @Panniantong， 打扰一下。目前有 5 个已通过 @moxxxskaifa 审查并批准的 PR 等待合并，均已 approved 于 7 月 5 日：
这五个 PR 都是 bug 修复 / 兼容性改进，代码量不大，且均已通过 review。如果没有什么问题的话，能否麻烦您合并一下？或者是否还需要我们补充什么？ 非常感谢您维护这个项目，辛苦了！ CC @moxxxskaifa |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #446
Summary
agent-reach configure --from-browser chromepreviously extracted cookies for ALL supported platforms, over-collecting and persisting full-domain cookie strings. Add--platformflag to limit extraction.Changes
agent_reach/cli.py— add--platformargumentagent_reach/cookie_extract.py— filterPLATFORM_SPECSby platformtests/test_cookie_extract_perms.py— 3 new testsVerification