Repository navigation
fix: classify Go SDK response body timeouts - #18362
Open
Hanabi9248 wants to merge 2 commits into
Open
Hanabi9248 wants to merge 2 commits into
Hanabi9248 wants to merge 2 commits into
Conversation
Signed-off-by: Hanabi <317387557+Hanabi9248@users.noreply.github.com>
Author
|
Updated the contribution branch with current |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an API server sends HTTP headers and then stalls while sending JSON,
SubmitOCRandGetStatusreturnResponseFormatErroreven though the request timed out. Callers checking forRequestTimeoutErrormiss this case.Recognize timeout errors from the JSON decoder and preserve the underlying cause. Malformed JSON still returns
ResponseFormatError.Added local HTTP-server tests for delayed and malformed bodies through both public methods. The two timeout cases fail before the change.
go test ./...andgo vet ./...pass for the Go SDK.