Repository navigation
feat(role-manager): adopt the UI Kit DataTable for all tables - #140
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DataTable@openzeppelin/ui-componentsexactly to3.12.0Tooling
@testing-library/domand@tanstack/virtual-core@openzeppelin/ui-componentsruntime import in@openzeppelin/adapter-polkadot@5.0.0Registry verification
@openzeppelin/ui-components: 3.12.0@openzeppelin/ui-components@3.12.0instance shared by the app, adapters,ui-react, andui-rendererfile:or.packed-packagesspecifiers.packed-packages/: absent after switching back to npm packagesVerification
pnpm build— passed (3 of 4 workspace projects)pnpm lint— passed (3 of 4 workspace projects, zero warnings)Live checks
Tested on
http://localhost:5173against the saved Sepolia contract:1440x1000: five rows; toolbar and pager remain inside the frame; previous/next use chevrons; pager controls are 36px; selection column is 48px1440x1000: 20 rows on page 1; date/action/role toolbar and relative pager remain inside the frame1440x700: no blank band below the footer; next-page scroll resets1289 -> 0; previous-page scroll resets1060 -> 0; page status/focus handoff remains accessible1440x1000: five rows rendered through the UI Kit table1440x1000: Pending Role Changes renders the expected no-pending empty stateScreenshots
gh pr createdoes not support uploading binary attachments, so screenshots were captured locally under/tmp/rm-datatable-screenshots/final/:authorized-accounts-1440x1000.png— framed toolbar, five-row table, and in-frame pagerrole-changes-1440x700-bottom.png— short viewport with pager directly above the footer and no blank bandrole-changes-after-next-1440x700.png— page 2 after scroll resetrole-identifiers-1440x1000.png— Role Identifiers tabledashboard-1440x1000.png— Pending Role Changes empty stateBehavioral notes
Made with Cursor