Skip to content

Wait for the open mining rounds to carry the reward config before settling in the traffic-rewards gate - #212

Merged
0xNeshi merged 2 commits into
mainfrom
fix-cip104-rewards-script
Oct 8, 2026
Merged

0xNeshi merged 2 commits into
mainfrom
fix-cip104-rewards-script

Conversation

@0xNeshi

@0xNeshi 0xNeshi commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

The scheduled live-ledger-gates run of 2026-10-06 failed in cip0104-traffic-rewards:
https://github.com/OpenZeppelin/canton-specs/actions/runs/37409532788/job/112094606399

[traffic-rewards] round 4 minting allowance of the app-provider: 1307.2614000000 CC
[traffic-rewards] FAIL: the reward coupon of round 4: no result after 900s (181 attempts)

Each open mining round stores the reward config of the moment it opened, and the SV processes a round by that stored config. The harness settled right after the vote took effect, so the traffic landed in a round that had opened under the old config. The SV ran that round through the dry-run triggers, which compute the allowance Scan reports but mint no RewardCouponV2, and the harness waited for a coupon that never existed. Whether the traffic lands in an old or a new round depends on where the vote falls in the round cycle, so the failure was intermittent. The re-run of the same commit passed.

Changes

  • After the vote takes effect, the harness polls Scan until every open round carries the traffic-based reward config, and only then settles. Splice keeps three rounds open at once, so this adds about three rounds to the run.
  • The evidence JSON records the rounds that were open when the settlements started.
  • The README and the gate script header describe the wait.

@0xNeshi 0xNeshi self-assigned this Oct 7, 2026

@ericnordelo ericnordelo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@0xNeshi
0xNeshi merged commit a3a9cf8 into main Oct 8, 2026
6 checks passed
@0xNeshi
0xNeshi deleted the fix-cip104-rewards-script branch October 8, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants