Skip to content

build: configure ty and fix type annotations - #473

Open
0xWelt wants to merge 1 commit into
mainfrom
build/ty-config
Open

0xWelt wants to merge 1 commit into
mainfrom
build/ty-config

Conversation

@0xWelt

@0xWelt 0xWelt commented May 10, 2026

Copy link
Copy Markdown
Member
  • Add tool.ty configuration to pyproject.toml\n- Fix type annotations and remove unnecessary type: ignore comments across the codebase\n- Update AGENTS.md to reflect current development workflow

@0xWelt
0xWelt requested a review from huan-yp May 10, 2026 04:41
@0xWelt
0xWelt force-pushed the build/ty-config branch 2 times, most recently from 1995a76 to 9bc5c5b Compare May 10, 2026 09:30
@codecov

codecov Bot commented May 10, 2026

Copy link
Copy Markdown

@0xWelt
0xWelt force-pushed the build/ty-config branch 4 times, most recently from e0bb39f to 6a1be3f Compare May 10, 2026 09:58
@0xWelt
0xWelt force-pushed the build/ty-config branch from 6a1be3f to 176eec9 Compare May 24, 2026 04:38
@0xWelt
0xWelt force-pushed the build/ty-config branch 2 times, most recently from bd85aeb to 94ec502 Compare August 16, 2026 10:17
@0xWelt
0xWelt requested a review from yltx August 16, 2026 10:31
@0xWelt

0xWelt commented Aug 16, 2026

Copy link
Copy Markdown
Member Author

Hi @yltx, I remember you handle the releases for this repo. This PR upgrades the ty type checker to v0.0.72 (official astral-sh/ty-pre-commit hook), rebased onto the latest main, with all type errors fixed and CI passing (lint + test). Could you please kindly review when you have a moment? Thanks!

CC @huan-yp

- Configure ty type checker (0.0.72) with official astral-sh/ty-pre-commit hook
- Add codecov.yml to relax patch threshold for type-annotation PRs
- Fix type annotations across combat/ops/server/ui modules
- Fix preparation.py to preserve main behavior (tolerate None ocr)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant