Skip to content

spec: AUDIO-IN-1 — lang authority basis; bridge cites; sleep scope; STT-failure rule - #144

Open
JarbasAl wants to merge 1 commit into
devfrom
spec/audio-in-audit
Open

spec: AUDIO-IN-1 — lang authority basis; bridge cites; sleep scope; STT-failure rule#144
JarbasAl wants to merge 1 commit into
devfrom
spec/audio-in-audit

Conversation

@JarbasAl

@JarbasAl JarbasAl commented Aug 4, 2026

Copy link
Copy Markdown
Member

🤖 Auto-generated by Claude Fable 5 (claude-fable-5) via Claude Code — NOT human-reviewed. Verify before acting. Cross-spec citations were model-verified against dev source; behavior-change sections need owner judgment.

Summary

  • AI1: reconciled §5 lang requiredness on ovos.utterance.handle with PIPELINE-1 §9.1 — optional on the topic, but the audio input service SHOULD always set it since it authoritatively knows the decode language by construction (it chose the STT decoder).
  • AI3: retargeted the §5.2 bridge citation from §4.2.1 to BRIDGE-1 §3.4.2 (managing-mode session assignment) + §3.2 (session_id NAT translation).
  • AI4: context.session.session_id on ovos.listener.sleep/ovos.listener.awoken documented as informational only — device-scope effect is identical for any value.
  • AI5: noted the deliberate absence of a listener-state query topic; sync-on-connect deployments derive state from the last-seen lifecycle signal.
  • AI6: ovos.listener.record.ended carries no completion guarantee; utterance arrival/absence is the only reliable signal.
  • AI7: STT failure/empty result — service MUST NOT emit ovos.utterance.handle with no usable transcription; diagnostics out of scope.
  • AI8: §4 clarifies that with in-process capture, TRANSFORM-1 §3.0's lang-parameter machinery degrades gracefully (starts unset, writeback is a no-op); chain output reaches the pipeline via session.detected_lang.
  • AO3 (from audio-out audit): adopted TRANSFORM-1 §3.1's sample rate/width/channels metadata contract as the pre-STT audio-format vocabulary, noting AUDIO-1's mime/sample_rate as the output-side counterpart.
  • AI2 skipped (GLOSSARY entry belongs to a different PR).

No version bump — no compatibility-class change.

Test plan

  • Docs-only change; reviewed cross-references against current PIPELINE-1, BRIDGE-1, TRANSFORM-1, AUDIO-1 source on this branch.

…TT-failure rule

Reconciles §5 lang requiredness with PIPELINE-1 §9.1 (optional on the
topic; audio input SHOULD always set it since it authoritatively knows
the decode language by construction), retargets the §5.2 bridge
citation to BRIDGE-1 §3.4.2 (assignment) + §3.2 (NAT), marks
context.session.session_id on sleep/awoken as informational, notes the
deliberate absence of a listener-state query topic, states
record.ended carries no completion guarantee, adds a MUST NOT-phantom
rule for STT failure/empty results, clarifies §4 transformer-chain
lang-parameter degradation under in-process capture, and adopts
TRANSFORM-1 §3.1's sample rate/width/channels metadata as the pre-STT
audio-format vocabulary (AUDIO-1's mime/sample_rate as the output-side
counterpart).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@JarbasAl, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 41 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9e104105-19fc-41e8-ab63-ba8bcbee1daf

📥 Commits

Reviewing files that changed from the base of the PR and between 1d3622b and 8aba6f2.

📒 Files selected for processing (2)
  • CHANGELOG.md
  • audio-in.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@JarbasAl
JarbasAl marked this pull request as ready for review August 4, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant