Skip to content

spec: OVOS-INTENT-2 — .prompt reader carve-out; entity-exclusion wire carrier named - #138

Open
JarbasAl wants to merge 1 commit into
devfrom
spec/intent-2-audit
Open

spec: OVOS-INTENT-2 — .prompt reader carve-out; entity-exclusion wire carrier named#138
JarbasAl wants to merge 1 commit into
devfrom
spec/intent-2-audit

Conversation

@JarbasAl

@JarbasAl JarbasAl commented Aug 4, 2026

Copy link
Copy Markdown
Member

🤖 Auto-generated by Claude Fable 5 (claude-fable-5) via Claude Code — NOT human-reviewed. Verify before acting. Cross-spec citations were model-verified against dev source; behavior-change sections need owner judgment.

Summary

Audit fixes for OVOS-INTENT-2 (I2-1/D7, I2-2, I2-3, I2-5). I2-4 (GLOSSARY) is deferred to its own PR.

  • §4.3 (I2-1/D7) — names the wire carrier for entity-level slot-value exclusions: the blacklist field of the OVOS-INTENT-4 §7.1 entity registration payload. Cross-PR dependency: the companion OVOS-INTENT-4 PR adds the blacklist field to the §7.1 entity registration payload — this spec now cites it as the delivery mechanism, so the two PRs should land together (or this one held until INTENT-4's field exists).
  • §3/§4.4/§5 (I2-2) — §3's shared reader is scoped explicitly to the five line-oriented roles (.intent, .dialog, .entity, .voc, .blacklist); .prompt no longer falls under "all resource files are line-oriented." §5 step 4 gains a .prompt bullet (whole-file verbatim, UTF-8/BOM handling only, no line splitting/stripping/comment filtering); steps 3 and 5 reworded to exempt .prompt. §4.4 defines an empty or whitespace-only .prompt as malformed (a file of only #-prefixed lines is NOT malformed — .prompt has no comment handling).
  • §2.2 (I2-3) — de-capitalized SHOULD/MAY to plain prose in the non-normative language-fallback subsection, consistent with its own "(non-normative)" label.
  • §2 (I2-5) — the slot-name-charset rule now covers any resource base name that denotes a slot (an .entity, or a .blacklist paired with one per §4.3), not only .entity.

No version bump — these are clarifications/scoping fixes, not compatibility-class changes.

Test plan

  • Read §3, §4.3, §4.4, §5 end to end for internal consistency.
  • Confirm INTENT-4 §7.1 gains the blacklist field in the companion PR before/alongside merge.
  • CHANGELOG entry reviewed.

🤖 Generated with Claude Code

… carrier named

- §4.3 names the wire carrier for entity-level slot-value exclusions: the
  `blacklist` field of the OVOS-INTENT-4 §7.1 entity registration payload
  (companion intent-4 PR adds the field).
- §3 scoped to the five line-oriented roles; §5 steps 3-5 and §4.4 carve out
  `.prompt` (whole-file verbatim, no line filtering) and define an empty or
  whitespace-only `.prompt` as malformed.
- §2.2 SHOULD/MAY de-capitalized to match its non-normative label.
- §2 slot-name rule reworded to cover any base name denoting a slot, not
  only `.entity`.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@JarbasAl, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 41 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9b1783d6-77b6-44f8-b1d3-31a2a1933c30

📥 Commits

Reviewing files that changed from the base of the PR and between 1d3622b and a019e89.

📒 Files selected for processing (2)
  • CHANGELOG.md
  • intent-2.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@JarbasAl
JarbasAl marked this pull request as ready for review August 4, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant