Conversation
Contributor
|
Can you just add the rest of the buttons as seen here? - https://github.com/OpenStickCommunity/GP2040-CE/pull/1705/changes |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing the SNES input addon with a NES controller, I found that whenever all buttons were released, the last pressed button would remain pressed.
When the controller is polled, the polling function assigns a type to snes->type. From my testing, if no buttons are pressed, the type is set to SNES_PAD_NONE, which results in the buttons not updating, and the last pressed button being held down.
This code fixes that by providing a fallback case that resets all buttons when the type is not set to SNES_PAD_BASIC, SNES_PAD_NES, or SNES_PAD_MOUSE.