Rotary Encoder's "Allow Wrap around" prevents saving the configuration if enabled

[MatteoGodzilla]

• I have checked documentation and the rotary encoder page does not say anything about this problem
• I have checked in the github issues for this problem and it is not already reported
• Issue is present on version v.0.7.12

Expected Behavior

Enabling the option and clicking save would soft-refresh the page and report "saved successfully" at the bottom

Current Behavior

When configuring Rotary encoders, it is possible to save the configuration of everything except the option for "allow wrap around", because when pressing the save button after enabling this option for at least one of the two encoders the save button does not soft-refresh the page.
When refreshing the configurator and going into the same section, old values are shown.

I personally have not tested with older firmware versions, i have found issue #1503 but it is closed

Context

Version, as reported from the web configurator

Pico (GP2040-CE_0.7.12_Pico.uf2)
Current: v0.7.12
Latest: v0.7.12
Architecture: rp2040
Build Type: Release
Build: 0014e4a

This is not a commercial device, but one controller i'm personally developing.

Rotary encoder is configured like this (even though i don't think it's causing the issue):

• Pin A: 27
• Pin B: 26
• PPR: 600
• Multiplier: 1
• Reset after: 0ms
• Control mode: Left Analog Y

Operating System: Linux
Browser: Firefox

Steps to Reproduce

• Enable Rotary Encoder add-on
• Enable Encoder 1
• Set up just the pins
• Save -> Should display "saved correctly"
• Enable "allow wrap around for encoder 1"
• Save -> Does not work

[mistapee]

Do you find once you click 'allow wrap around' you can't deselect it? The page itself errors and shows in the browser console and everything from there borks, i don't remember the specifics as i gave up but have used rotary encoder option for an IIDX controller since but that didn't need wrap around

[MatteoGodzilla]

I honestly can't remember, when I'll have access to the pico again I'll test it and report.
I am interested in how did you manage to make an IIDX controller without wrap around, cause that is exactly what i am trying to make.

[mistapee]

I honestly can't remember, when I'll have access to the pico again I'll test it and report. I am interested in how did you manage to make an IIDX controller without wrap around, cause that is exactly what i am trying to make.

IIDX doesn't wrap around like SDVX - turntable is simply an up/down switch (on a whole bunch i have and taken apart, and in dj hero, it's an optical switch that literally just triggers that it is going up or down), don't set wrap around, set as up/down D-pad, set the 'reset after' so that is goes back to neutral otherwise it will stick in the last direction pushed. if you touch the turntable on the outside edge or the inside edge your up and down is inverted, to solved that switch the order of the 2 gpio pins in the rotary encoder section. i have a guide for it in my iidx repo.