feat: Add alexandrebayanza-maker as a contributor - #998
Conversation
|
Congratulations on completing the How to Contribute to Open Source chapter of the Intro to Open Source Course with your contribution to this repository, @alexandrebayanza-maker! You're almost to the end of the course! |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congratulations on submitting your first Pull Request! 🎉
We appreciate your contribution. Feel free to join the conversation in our
Community and say hello!
adiati98
left a comment
adiati98
left a comment
There was a problem hiding this comment.
Thank you for your contribution! ✨
There are a couple of things for you to address:
-
We don't want to modify the
package-lock.json. Please revert the file to its original state. -
We have merged a PR before yours. Please resolve the merge conflicts before we can review your PR.
Please let me know if you have questions or need any help. 😊
|
After resolving merge conflicts, have you run the command to generate the README? I don't see the number in the badge increases. Please read and follow the instructions thoroughly: https://learn.osscommunities.com/intro-to-oss/how-to-contribute-to-open-source/#merge-conflicts-in-the-guestbook-repository |
Thanks for the feedback. I have checked on it and followed the instruction, would you please recheck, and let me know if there is something I miss. |
|
@alexandrebayanza-maker I think you missed step 3 in the instructions. |
adiati98
left a comment
adiati98
left a comment
There was a problem hiding this comment.
Well done and thank you for your contribution qmd the fix, @alexandrebayanza-maker! ✨
You can check out our pizza-verse repo if you want to contribute further! 🍕🍴
2 participants
Description
This PR adds
alexandrebayanza-makeras a contributor to the Guestbook project using the All Contributors tool. I generated the contributor section in the README and verified that my profile appears correctly.What type of PR is this? (check all applicable)
Related Issues
Fixes #997
Contributors Checklist
I've read through the Getting Started section
Have you run
npm run contributors:generateto generate your profile and the badge on the README?Added to documentation?
Screenshot (Required for PR Review)
[optional] What GIF best describes this PR or how it makes you feel?
Summary
Added myself as a contributor to the project as part of the Intro to Open Source course.
Fixes #997