Repository navigation
Conversation
The fmi-ls-dae draft only covers semi-explicit index-1 DAEs, which the manifest marks with <ContinuousStateDerivative> entries. Accept that form beside the fully implicit one of older exports: the FMU computes the derivatives, so a component's rows are x' - der(x) and then its residuals, and the Jacobian sparsity takes the derivative rows from the manifest's dependencies. Test DaeSemiExplicit1.py runs the DaeMode1.py loop with DaeSemiLoopA, exported by OpenModelica in the semi-explicit form. Assisted-by: Claude Opus 5.5
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1693 +/- ##
==========================================
+ Coverage 30.22% 30.32% +0.09%
==========================================
Files 74 74
Lines 14661 14680 +19
Branches 9432 9444 +12
==========================================
+ Hits 4431 4451 +20
+ Misses 8892 8891 -1
Partials 1338 1338
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1692.
What
fmi-ls-dae only defines semi-explicit index-1 DAEs since modelica/fmi-ls-dae#67. In that form the manifest has
<ContinuousStateDerivative>entries, the FMU computes the derivatives in DAE mode, and the residuals only cover the algebraic variables. OpenModelica exports this form from OpenModelica/OpenModelica#17714 on. OMSimulator rejected it so far.<ContinuousStateDerivative>is the fully implicit form of older exports (DaeLoopA), and works as before.x' - der(x)fromfmi3GetContinuousStateDerivatives, then its residuals. The master does not set the derivatives, and the derivative value references come from the manifest.<ContinuousStateDerivative>dependencies. Each row also gets its own state column, throughx'.Tested locally
DaeSemiExplicit1.py: theDaeMode1.pyloop withDaeSemiLoopA, which is the same model exported by OpenModelica with #17714 (--simCodeTarget=C+Rust, so x86_64-linux only). It gives x(1) = 0.701445, the analytic value, with the same IDA statistics asDaeMode1.py. The system has 6 unknowns instead of 5.ctest: 130 of 130 pass on Linux.AI use: written with Claude Code; the changes and test runs above were checked by hand.
🤖 Generated with Claude Code