Skip to content

Restore the connection between the first reserve phase and the final regular phase. Fix a logic hole in the initial conditions setting for controls in the energy method. - #1287

Merged
jkirk5 merged 9 commits into
OpenMDAO:mainfrom
Kenneth-T-Moore:ic_logic1
Aug 31, 2026

Conversation

@Kenneth-T-Moore

@Kenneth-T-Moore Kenneth-T-Moore commented Aug 28, 2026

Copy link
Copy Markdown
Member

Summary

This fixes a couple of bugs that @cmbenne3 identified.

  1. The first reserve phase was completely unlinked from the previous regular phase. While there is probably a usecase for this, most of the time we are going to want at least the mass to be linked. This fix restores connection of all variables, except those that are given a value on both sides.
  2. There was a hole in the logic for figuring out the initial controls in height energy, which allowed it to try to set a None value. This hole has been covered, and a nominal value is used even if there are no guesses, bounds, or constraints on either end.

NOTE: This PR also includes #1286 , so that should be reviewed first.

Related Issues

  • Resolves #

Backwards incompatibilities

None

AI Usage

Disclose any AI usage in this PR, including models used and files affected.

@jkirk5

jkirk5 commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Waiting for #1286 which currently has merge queue issues

@jkirk5
jkirk5 added this pull request to the merge queue Aug 31, 2026
Merged via the queue into OpenMDAO:main with commit e9951c6 Aug 31, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants