Ia1251 remove get option defaults - #1283
Open
hschilling wants to merge 10 commits into
Open
Conversation
…tems/geometry/gasp_based/test/test_wing.py
jkirk5
reviewed
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
get_option_defaults()in unit tests with minimal, explicitAviaryValues()seeded only with the options each component under test actually declares viaadd_aviary_option. This makes each test's option dependencies visible at the call site and removes hidden coupling to the global metadata defaults.Not all tests were migrated to the new approach. This is just a large number of them. More will be done in a future PR.
Why
get_option_defaults()returns every option in_MetaData. Tests using it fail silently when defaults drift, and it's impossible to tell from the test which options actually matter.Approach
For each migrated test:
add_aviary_optiondeclarations across that tree.AviaryValues()with only options the test needs to override.Related Issues
get_option_defaults#1251Backwards incompatibilities
None
AI Usage
AI was used in part for all the changes in this PR.