Repository navigation
fix(tests): avoid getStubBuilder and fix line length for CI - #290
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
[Low impact] The PR appears safe to merge.
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the test-only PHPUnit compatibility and formatting changes.
No open issues 🎉
What changed in this PR
This PR addresses test-suite CI failures by replacing unsupported PHPUnit builder calls and fixing a PHPCS line-length violation. Production code is unchanged.
Changes:
- Replace
getStubBuilder()withgetMockBuilder()orcreateStub()in inspector tests. - Split a long method chain in the template fallback resolver test.
| File | Description |
|---|---|
| tests/Unit/Service/TemplateOverride/TemplateFallbackResolverTest.php | Wraps a method chain to satisfy line-length checks. |
| tests/Unit/Service/Inspector/Cache/BlockCacheCollectorTest.php | Uses the mock builder for partial block doubles. |
| tests/Unit/Model/TemplateEngine/Decorator/InspectorHintsTest.php | Uses createStub() for parent and child block doubles. |
Review effort: Balanced
dermatz
enabled auto-merge (squash)
November 12, 2026 22:29
dermatz
disabled auto-merge
November 12, 2026 22:29
Merged
dermatz
added a commit
that referenced
this pull request
Nov 12, 2026
Take main's fix (#290) for getStubBuilder and the overlong line, and drop the now redundant phpstan.neon ignore. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes failing PHPCS (line length in TemplateFallbackResolverTest) and Static Analysis (getStubBuilder() undefined with the PHPUnit version installed by Magento) on main.