You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feat(theme): offer to build parent themes for build and watch - #284
### Issue 1
src/Service/ThemeParentResolver.php:undefined-100`isVendorTheme` matches `/vendor/` anywhere in the full path. A local parent at `/magento-root/app/design/frontend/vendor/base` is therefore skipped, even with `--with-parents`. Its assets remain missing or stale while the child builds or starts watching.
Match the Composer directory under the Magento root instead, as `DependencyUpdater::isVendorTheme` already does.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Summary
Adds optional parent builds to theme:build and theme:watch.
Theme builds can include usable parents before the selected themes.
Theme watching can build usable parents once before watching the selected theme.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
The parent-selection flow can still prompt under --no-interaction and omit ancestors after a misspelled theme code is corrected, even with --with-parents.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Theme resolution can select admin ancestry for a frontend theme with the same code, causing the wrong parent chain to be built or watched, while confirmation-prompt behavior lacks interactive test coverage.
When an automatically added parent's build returns false, processBuildThemes() records the failure but still builds its child, which can consume missing or stale parent assets. Preserve the parent dependencies and skip dependent child builds after a parent fails in both verbose and non-verbose execution; unrelated selected themes can still proceed.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
The new interactive confirmation remains untested, with coverage needed for acceptance, rejection, and non-interactive skipping under controlled terminal detection.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
The new interactive confirmation remains untested for acceptance, rejection, non-interactive safeguards, and restoration of prompt environment variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
theme:buildandtheme:watchnever touched the parent of a child theme. They now offer to build the whole parent chain first.ThemeParentResolverreturns buildable ancestors, topmost first (skips parents without path or builder).--with-parents/--no-parents. Non-interactive environments (CI) default to not building parents, so existing behaviour is unchanged.Notes
Not yet tested against a real child theme (e.g. videotronic → videor → base).