Replace assert() calls with CY_ASSERT() macro and add CY_CONFIG_HEADER - #72
Merged
pavel-kirienko merged 12 commits intoJul 24, 2026
Merged
Conversation
pavel-kirienko
requested changes
Jul 24, 2026
bjsowa
marked this pull request as ready for review
July 24, 2026 15:28
|
|
||
| #include "cy.h" | ||
| #include <stdint.h> | ||
| #include <stdlib.h> |
Contributor
Author
There was a problem hiding this comment.
must have been some residue
pavel-kirienko
requested changes
Jul 24, 2026
pavel-kirienko
left a comment
pavel-kirienko
left a comment
Member
There was a problem hiding this comment.
Aside from the apparently unnecessary #include <stdlib.h>, we also have no longer needed #include <assert.h> in cy_can_socketcan.c and udp_wrapper.c.
| #define CY_ASSERT(x) assert(x) | ||
| #endif | ||
|
|
||
| #define WKV_ASSERT(x) CY_ASSERT(x) |
Member
There was a problem hiding this comment.
Suggested change
| #define WKV_ASSERT(x) CY_ASSERT(x) | |
| #ifndef WKV_ASSERT | |
| #define WKV_ASSERT(x) CY_ASSERT(x) | |
| #endif |
pavel-kirienko
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.