fix(ci): add telemetry profile to dev grafana service (#16777)#16778
Open
YAMRAJ13y wants to merge 1 commit into
Open
fix(ci): add telemetry profile to dev grafana service (#16777)#16778YAMRAJ13y wants to merge 1 commit into
YAMRAJ13y wants to merge 1 commit into
Conversation
…rm#16777) The dev docker-compose declared the grafana service without a profile while it depends_on the telemetry-profiled prometheus service. As a result the documented 'docker compose up -d' failed with 'invalid compose project'. Add 'profiles: [telemetry]' to the grafana service, consistent with the other telemetry services (prometheus, otlp, jaeger, pyroscope), so the default dev stack starts and grafana comes up only with '--profile telemetry'. Closes OpenCTI-Platform#16777
Author
|
The failing Backend / Integration tests run looks like an unrelated CI infrastructure flake rather than something caused by this change. The job log ends with the platform failing its startup dependency check against Elasticsearch: This PR only adds |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The dev stack in
opencti-platform/opencti-devcould not be started with the documented command:grafanahad noprofileswhiledepends_onthetelemetry-profiledprometheus, making the default project invalid. This change addsprofiles: [telemetry]tografana, consistent with the other telemetry services (prometheus,otlp,jaeger,pyroscope).Related issues
Closes #16777
How to test
From
opencti-platform/opencti-dev:Verified locally: the default project is valid, grafana is excluded by default and included with
--profile telemetry, anddocker compose up -dbrings up the core dependencies.