Skip to content

fix(translation): add translations missing in leftBar (#16741)#16744

Merged
CelineSebe merged 2 commits into
masterfrom
issue/16741
Jun 24, 2026
Merged

fix(translation): add translations missing in leftBar (#16741)#16744
CelineSebe merged 2 commits into
masterfrom
issue/16741

Conversation

@CelineSebe

@CelineSebe CelineSebe commented Jun 22, 2026

Copy link
Copy Markdown
Member

Proposed changes

  • add t_i18n

Related issues

How to test this PR

1- Take ne OCTI english version, ex: in french version, go to the left menu
2- Go to "menaces"

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant use cases (coverage and e2e)
  • I added/updated the relevant documentation (either on GitHub or on Notion)
  • Where necessary, I refactored code to improve the overall quality

Further comments

Threat actors (individual) must be translated
image

@github-actions github-actions Bot added the filigran team Item from the Filigran team. label Jun 22, 2026
@CelineSebe CelineSebe self-assigned this Jun 22, 2026
@CelineSebe CelineSebe marked this pull request as ready for review June 22, 2026 13:01
Copilot AI review requested due to automatic review settings June 22, 2026 13:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the missing localization for the “Threat actors (individual)” entry in the left navigation menu by switching it from a hardcoded English label to the standard t_i18n(...) translation helper, aligning it with the other menu items.

Changes:

  • Localize the “Threat actors (individual)” left-menu label using t_i18n(...).

@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 24.13%. Comparing base (4e88982) to head (38ba098).
⚠️ Report is 42 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #16744      +/-   ##
==========================================
+ Coverage   23.99%   24.13%   +0.13%     
==========================================
  Files        3268     3272       +4     
  Lines      173116   174665    +1549     
  Branches    42909    43810     +901     
==========================================
+ Hits        41541    42155     +614     
- Misses     131575   132510     +935     
Flag Coverage Δ
opencti-client-python 46.30% <ø> (ø)
opencti-front 5.61% <ø> (+0.07%) ⬆️
opencti-graphql 66.83% <ø> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Archidoit

Copy link
Copy Markdown
Member

Can you also add the translations for these 2 missings labels in LeftBar.tsx :
image

@CelineSebe CelineSebe changed the title fix(translation): "Threat actors (individual)" translation (#16741) fix(translation): add translations missing in leftBar (#16741) Jun 23, 2026
@CelineSebe CelineSebe merged commit 7d44b88 into master Jun 24, 2026
48 checks passed
@CelineSebe CelineSebe deleted the issue/16741 branch June 24, 2026 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team Item from the Filigran team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(translations): threat translation in left menu

4 participants