feat(observables): auto-populate AS number from Autonomous-System name (#8383)#16743
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the frontend Stix Cyber Observable creation drawer to improve the Autonomous System creation UX by deriving the mandatory number field from the name when the name follows the AS<number> pattern.
Changes:
- Add a special-case handler for
Autonomous-Systemnameinput to parseAS1234-style values and populatenumber. - Minor JSX formatting/indentation adjustments around the bulk creation button rendering.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #16743 +/- ##
==========================================
- Coverage 24.09% 24.09% -0.01%
==========================================
Files 3271 3271
Lines 173266 173274 +8
Branches 42956 42960 +4
==========================================
Hits 41744 41744
- Misses 131522 131530 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
When creating an Autonomous-System observable, automatically parse and set the `number` field if the name matches the pattern `AS<number>` (e.g., typing "AS1234" fills in 1234 as the AS number).
0b8e828 to
b3d69a1
Compare
|
It works well, but I have a question. What about the update? Do we want the number to change automatically if we change the name? |
Working on updates was planned but:
So the feature is only useful at creation. |
When creating an Autonomous-System observable, automatically parse and set the
numberfield if the name matches the patternAS<number>(e.g., typing "AS1234" fills in 1234 as the AS number).Proposed changes
ASRelated issues
How to test this PR
Checklist
Further comments