feat(google-ti-feeds): enable IOC fetching for campaigns (#5793)#6785
Open
romain-filigran wants to merge 2 commits into
Open
feat(google-ti-feeds): enable IOC fetching for campaigns (#5793)#6785romain-filigran wants to merge 2 commits into
romain-filigran wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the Google Threat Intelligence (GTI) Feeds connector’s campaign orchestration to fetch and convert additional IoC-related subentities (beyond the existing campaign relationships), aligning campaign ingestion more closely with the connector’s broader relationship-fetching approach.
Changes:
- Enabled campaign subentity fetching for
domains,files,urls, andip_addressesin the campaign orchestrator. - Updated orchestration test expectations to account for the newly fetched/converted campaign IoC relationships (as exercised by the existing stubs).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
external-import/google-ti-feeds/connector/src/custom/orchestrators/campaign/orchestrator_campaign.py |
Adds IoC subentity types to the campaign relationship fetch list so the orchestrator can retrieve/convert them. |
external-import/google-ti-feeds/tests/custom/test_orchestrator.py |
Updates expected log/message counts to reflect additional campaign IoC processing from the stubs. |
Comment on lines
+86
to
+89
| "domains", | ||
| "files", | ||
| "urls", | ||
| "ip_addresses", |
1d2f4de to
d8b4114
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
add "domains", "files", "urls" and "ip_addresses" to campaign subentity types, allowing the campaign orchestrator to fetch and convert IOCs alongside existing relationships. Update test expectations
accordingly.
Related issues
Checklist
Further comments