Debug monitor enabled in release build

[mcarans]

In preparation for reducing to just one build in a future PR, enable the debug monitor in the deployment build. While we might publish only a deployment build in future, other builds with even more debug functionality would be possible to build so this build should have only what is needed for OXP devs not necessarily all debug functionality.

• Created OO_DEBUG_MONITOR_ENABLED
• Tried to replace only those if/ifdefs with OO_DEBUG, NDEBUG related code needed for debug monitor functionality rather than just including it all
• Test workflow tests deployment instead of dev
• Possible problems are: either I have not included something useful for OXP debugging in the monitor/logs or I have included something that isn't really needed (which is less of an issue)
• Tested some debug monitor functionality but I don't know much about how it's used for OXP development

[mcarans]

@phkb Please can you test the deployment build with debug monitor trying the kind of functionality an OXP dev would use. I would like to find out if anything is missing which is useful to an OXP dev or which you think should be available in a deployment build in the console/logs (and less critically if anything is included which isn't needed).

@oocube You said "But I can tell that I always run the dev build. It contains the debug console which allows OoliteStarter to act as MQTT bridge. And that again allows Oolite users to create additional IO devices (buttons, displays, ...)." - please can you check if the deployment build from this PR works for that.

[oocube]

I checked ./Oolite-1.93.1-PullRequest756.3158-deployment-x86_64.AppImage
It connects to the debug console (and communicates this in the logs as well), but I cannot launch from the station.

When I launch, the game does not start running. Pressing 1 again, again I see the start sequence and again the game does not start running. So something is off.

Why are you trying to pimp the deployment build when we can still use the dev one? A rename would be sufficient. Plus as a first step I'd simply document for users the difference and nudge them to the dev build unless someone spots a reasonable difference.

[mcarans]

Thanks for checking. I will look into that. The Windows store and Flathub can only have one build so ideally it should be debug console enabled. Unsetting NDEBUG includes the debug console but that includes a lot of other debug stuff and logging that I assume must have been used for testing during development. Presumably it had a significant impact on performance which was why it was not included all along. That's why I'm trying to see whether I can include the debug console without including all debug stuff but failing that we could just make the test version (which I understand is meant for OXP devs) into the deployment.

[mcarans]

Had a detour with clang 23 coming out and causing GNUstep Base build to fail. I've since discovered that the deployment issue is not from changes in this PR but from clang format (ie. current master deployment build is broken). Specifically I have traced it to include reordering and will try to find where the problem lies: #757.