SGL 2026 preset update and altar Ganon BK hint with vanilla LACS crash

[Elagatua]

SGL 2026 is going back to using all locations reachable instead of beatable only. When switching back, I discovered a localization crash that only affects the SGL preset.

Generation crashes during ROM patching for any settings combination that uses Ganon's Boss Key on LACS with the vanilla LACS condition (Shadow + Spirit Medallions) while the Temple of Time Altar misc hint is enabled:

  Patches.py:1802   build_altar_hints(...)
  Hints.py:1947     adult_text += build_ganon_boss_key_string(world)
  Hints.py:2079     "verb": verb_singular if count == 1 else verb_plural
UnboundLocalError: cannot access local variable 'verb_plural' where it is not associated with a value

Two separate problems on the same code path, both introduced by the localization refactor in 56b5047:

1. build_ganon_boss_key_string() unpacks verb_singular / verb_plural in the non-vanilla lacs_condition branch, but the vanilla branch assigns only item_req_string and count. Both branches then fall through to the shared hint_text.ganon_lacs_bk lookup, which reads the verbs — so the vanilla path raises UnboundLocalError. Fixed by binding the verbs from the ganon_medallions hint text, which matches the Shadow and Spirit Medallions that the vanilla condition actually requires, and keeps the strings translatable rather than hardcoding "is"/"are".

2. The English ganon_lacs_bk string references {item_req_string}, but the call site passes item_req. Language._resolve_external indexes the externals dict directly, so this would have raised KeyError as soon as the first bug was fixed. The Japanese string and the sibling ganon_grant_bk string both already use {item_req}, so this is just a typo in the one English entry. Fixed in data/lang/property_build.py and the generated data/lang/English/property.json.

The rendered text is unchanged from the pre-refactor behavior: provided by Zelda once the #Shadow and Spirit Medallions# are retrieved.

No preset shipped in presets_default.json on Dev hits this combination, which is why it went unnoticed — it was found via the SGL tournament preset that does.

Testing

• Reproduced the crash with shuffle_ganon_bosskey: on_lacs + lacs_condition: vanilla + altar in misc_hints; confirmed it is deterministic and seed-independent.
• The same settings generate successfully after the fix (patch file, cosmetics log and spoiler log all written).
• Checked the rendered altar string in both English and Japanese. English matches the pre-refactor wording exactly; Japanese is unaffected, as its template does not use {verb}.
• Unittest.TestLanguageFile passes, covering key parity between property_build.py and the per-language property.json files.