Skip to content

Expand “Under Consideration” description and add advanced tricks exception - #2531

Merged
fenhl merged 2 commits into
OoTRandomizer:Devfrom
fenhl:preaccept-adv-tricks
Mar 15, 2026
Merged

fenhl merged 2 commits into
OoTRandomizer:Devfrom
fenhl:preaccept-adv-tricks

Conversation

@fenhl

@fenhl fenhl commented Mar 5, 2026 •

Copy link
Copy Markdown
Collaborator

Adds an exception to the requirement for “enhancement” (new feature) issues/PRs to go through the nomination process, allowing the maintainers of advanced logic to add tricks and glitches to it more easily.

I've also taken the opportunity to expand the description of the Under Consideration status label to clarify some questions and misconceptions I've seen, and to add a small note to the release cycle section letting people know about the pin in #dev-public-talk.

@dotzo @shirosoluna please confirm whether you're okay with your GitHub usernames being added to our documentation.

@fenhl
fenhl requested a review from cjohnson57 March 5, 2026 04:39
@fenhl fenhl added Status: Needs Review Someone should be looking at it Trivial Affects only spacing, style, and/or comments Component: Tricks/Glitches Unusual maneuvers Component: Documentation Affects user-facing help messages or public API docs Type: Maintenance Code style, infrastructure, updating dependencies labels Mar 5, 2026
@shirosoluna

Copy link
Copy Markdown

Adds an exception to the requirement for “enhancement” (new feature) issues/PRs to go through the nomination process, allowing the maintainers of advanced logic to add tricks and glitches to it more easily.

I've also taken the opportunity to expand the description of the Under Consideration status label to clarify some questions and misconceptions I've seen, and to add a small note to the release cycle section letting people know about the pin in #dev-public-talk.

@dotzo @shirosoluna please confirm whether you're okay with your GitHub usernames being added to our documentation.

yep, no problem from me

@shirosoluna

Copy link
Copy Markdown

can this also extend to bugfixing for logic?

@fenhl

fenhl commented Mar 5, 2026

Copy link
Copy Markdown
Collaborator Author

Bugfixes already get to skip the “Under Consideration” label, it only applies to enhancements.

@fenhl fenhl added Status: Blocked Waiting for something else to happen first and removed Status: Needs Review Someone should be looking at it labels Mar 6, 2026
@dotzo

dotzo commented Mar 15, 2026

Copy link
Copy Markdown

ok

@fenhl fenhl removed the Status: Blocked Waiting for something else to happen first label Mar 15, 2026
@fenhl fenhl added this to the next milestone Mar 15, 2026
@fenhl
fenhl merged commit d90421b into OoTRandomizer:Dev Mar 15, 2026
6 checks passed
@fenhl
fenhl deleted the preaccept-adv-tricks branch March 15, 2026 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Documentation Affects user-facing help messages or public API docs Component: Tricks/Glitches Unusual maneuvers Trivial Affects only spacing, style, and/or comments Type: Maintenance Code style, infrastructure, updating dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants