Skip to content

Make sure to retry fast confirmation on failure #3640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshuacolvin0 merged 1 commit into from
Sep 15, 2025
Merged

Make sure to retry fast confirmation on failure #3640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions bold/assertions/confirmation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,11 @@ func (m *Manager) keepTryingAssertionConfirmation(ctx context.Context, assertion
confirmed, err = m.chain.FastConfirmAssertion(ctx, creationInfo)
if err != nil {
log.Error("Could not fast confirm latest assertion", "err", err)
return
}
if confirmed {
} else if confirmed {
assertionConfirmedCounter.Inc(1)
log.Info("Fast Confirmed assertion", "assertionHash", creationInfo.AssertionHash)
return
}
return
}
prevCreationInfo, err := retry.UntilSucceeds(ctx, func() (*protocol.AssertionCreatedInfo, error) {
return m.chain.ReadAssertionCreationInfo(ctx, creationInfo.ParentAssertionHash)
Expand All @@ -75,6 +73,17 @@ func (m *Manager) keepTryingAssertionConfirmation(ctx context.Context, assertion
case <-ctx.Done():
return
case <-ticker.C:
if m.enableFastConfirmation {
var confirmed bool
confirmed, err = m.chain.FastConfirmAssertion(ctx, creationInfo)
if err != nil {
log.Error("Could not fast confirm latest assertion", "err", err)
} else if confirmed {
assertionConfirmedCounter.Inc(1)
log.Info("Fast Confirmed assertion", "assertionHash", creationInfo.AssertionHash)
return
}
}
opts := m.chain.GetCallOptsWithDesiredRpcHeadBlockNumber(&bind.CallOpts{Context: ctx})
parentAssertion, err := m.chain.GetAssertion(
ctx,
Expand Down
Loading