Repository navigation
Accept per-microliter units for blood neutrophil counts - #706
Closed
TayaIntelligence wants to merge 1 commit into
Closed
TayaIntelligence wants to merge 1 commit into
TayaIntelligence wants to merge 1 commit into
Conversation
Allow unit concept 8647 for measurement concept 3017732 and add regression coverage using the packaged thresholds and production SQL. Fixes OHDSI#698.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #698.
Blood neutrophil count concept 3017732 (LOINC 26499-4) currently rejects unit concept 8647 (UCUM
/uL, per microliter). Add 8647 to its plausible-unit list in the shared concept-level thresholds ondevelop, preserving the existing units and the 5% violation threshold. No other concepts or numeric plausibility bounds are changed.Add SQLite-backed regression tests that load the packaged threshold data and execute the production
plausibleUnitConceptIdsSQL through SqlRender and DatabaseConnector. They cover/uL, existing units, an unrelated unit, zero/NULL units, unrelated measurements, and an empty table. Add RSQLite to Suggests and document the correction in NEWS.Validation
/uLis counted as a violation; after the fix: 23 assertions pass, with no failures, errors, warnings, or skips.executeDqChecks(14 scenario/path checks).--no-manual --ignore-vignettes, built with--no-build-vignettes): 0 errors, 0 warnings, and 1 existing NEWS-format NOTE. The NEWS parser emits the identical message for the original and modified sources.Tests used R 4.5.3, DatabaseConnector 8.0.0, SqlRender 1.19.7, CommonDataModel 1.0.1, and Eunomia 2.0.0. CommonDataModel/Eunomia are pinned to these official releases for this branch's CDM 5.3 test fixture. All validation data are synthetic; no production patient data or remote clinical database was used.
Terminology references