Initial @file by RamyGeorge · Pull Request #289 · OCamlPro/gnucobol

RamyGeorge · 2026-05-03T23:26:46Z

Summary

This pull request is intended to introduce the "@file" command line option to GnuCOBOL.

Motivation

Such option would no longer limit the amount of options to that of a given OS's Terminal size.

Changes

added initial implementation for "@" detection and reading File contents
Called new process_at_file in process_command_line

Misc

I Have left a few notes on current changes and hope for feedback

GitMensch

we'll need a force-push from a new local branch to not includes screen changes, it may or may not cherry-pick the current commit on that)

We then need test cases which also shows what the implementation wants to provide and then can have a look if the proposed changes work that way (= work on getting it there).

GitMensch

As seen in CI that currently leads to a SEGFAULT:

1197. run_extensions.at:1761: testing CALL unusual PROGRAM-ID. ...
../../tests/run_extensions.at:1815: $COMPILE_MODULE A@B.cob
/tmp/_actions-runner-working-dir/gnucobol/gnucobol/_build/tests/testsuite.dir/at-groups/1197/test-source: line 154: 75721 Segmentation fault      (core dumped) ( $at_check_trace; $COMPILE_MODULE A@B.cob ) >> "$at_stdout" 2>> "$at_stderr" 5>&-
--- /dev/null	2026-04-27 01:59:42.626967408 +0000
+++ /tmp/_actions-runner-working-dir/gnucobol/gnucobol/_build/tests/testsuite.dir/at-groups/1197/stderr	2026-05-18 21:19:44.588745273 +0000
@@ -0,0 +1,5 @@
+
+attempt to reference invalid memory address (signal SIGSEGV)
+
+cobc: aborting
+cobc: Please report this!
../../tests/run_extensions.at:1815: exit code was 139, expected 0
1197. run_extensions.at:1761:  FAILED (run_extensions.at:1815)

so there is still some stuff to do :-)

Most important: please always add Changelog entries as those document the changes you did - also helps for review - and getting the habit of always documenting at least on git push is a good thing; similar applies for the testsuite (would go into used_binaries.at)

GitMensch

nice progress

GitMensch · 2026-05-29T21:31:38Z

  /* Test whether ARGV[optind] points to a non-option argument.  */
 #define NONOPTION_P (argv[optind][0] != '-' || argv[optind][1] == '\0')

+


revert this non-change for cleaner diff

GitMensch · 2026-05-29T21:34:33Z

+        STOP RUN.   
+])
+
+AT_CHECK([echo "-x" > tempfile.txt


just use AT_DATA for that

GitMensch · 2026-06-02T09:22:21Z

@@ -500,11 +498,11 @@ process_at_file(const char* argument_values,int* compile_mode,int* atfile_size){
    	return NULL;
 	}


the old code here was better, you just need to add an additional scope {} around that; note that I'd suggest to do the define here and use all upper-case with a name that is unlikely conflict with any system header

codecov-commenter · 2026-06-02T16:37:57Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 65.51724% with 30 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (gitside-gnucobol-3.x@a3accbe). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
libcob/cobgetopt.c	64.70%	22 Missing and 8 partials ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@                   Coverage Diff                   @@
##             gitside-gnucobol-3.x     #289   +/-   ##
=======================================================
  Coverage                        ?   67.44%           
=======================================================
  Files                           ?       34           
  Lines                           ?    61615           
  Branches                        ?    16051           
=======================================================
  Hits                            ?    41555           
  Misses                          ?    14107           
  Partials                        ?     5953

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

GitMensch · 2026-06-30T08:53:39Z

   Modified for use in GnuCOBOL by Roger While
 */

+#include "libcob/common.h"


that change is unrelated and should be done - if at all - in a different commit (possibly added by clangd vscode extension - you can configure automated changes there)

GitMensch · 2026-06-30T08:54:07Z

file should be reverted -> no change

GitMensch · 2026-06-30T08:56:22Z

+This file is part of the libiberty library.
+Libiberty is free software; you can redistribute it and/or
+modify it under the terms of the GNU Library General Public
+License as published by the Free Software Foundation; either
+version 2 of the License, or (at your option) any later version.
+
+Libiberty is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+Library General Public License for more details.
+
+You should have received a copy of the GNU Library General Public
+License along with libiberty; see the file COPYING.LIB.  If
+not, write to the Free Software Foundation, Inc., 51 Franklin Street - Fifth Floor,
+Boston, MA 02110-1301, USA.  */


have a look at cobgetopt.c how to adjust the header

GitMensch · 2026-06-30T08:57:11Z


+2026-05-29  Ramy George <ramygeorge19@gmail.com>
+
+	* argv.c: extracted the argv.c file from GCC


argv.c: new file, extracted from libiberty [GCC version NNN], [youradjustments]

cobgetopt.h (cob_expandargv): added the expandargv function in header

Makefile.am (SOURCES): include argv.c

GitMensch · 2026-06-30T08:57:47Z

+/*  Create and destroy argument vectors.  An argument vector is simply an
+    array of string pointers, terminated by a NULL pointer. */
+
+#include "cobc/cobc.h"


there should be no cobc in libcob (only the other way around)

GitMensch · 2026-06-30T09:03:38Z

   arguments to the option '\0'.  This behavior is specific to the GNU
   `getopt'.  */

+COB_EXPIMP void cob_expandargv (int *argcp, char ***argvp);


we use unnamed parameters in our headers

GitMensch · 2026-06-30T09:04:12Z

GCC says:

../../libcob/argv.c:361:1: warning: 'cob_expandargv' redeclared without dllimport attribute: previous dllimport ignored [-Wattributes] 361 | cob_expandargv (int *argcp, char ***argvp) | ^~~~~~~~~~~~~~ ../../libcob/argv.c:512:1: warning: 'expandargstr' defined but not used [-Wunused-function] 512 | expandargstr (const char *progname, const char *val) | ^~~~~~~~~~~~ ../../libcob/argv.c:486:1: warning: 'countargv' defined but not used [-Wunused-function] 486 | countargv (char * const *argv) | ^~~~~~~~~ ../../libcob/argv.c:300:1: warning: 'writeargv' defined but not used [-Wunused-function] 300 | writeargv (char * const *argv, FILE *f) | ^~~~~~~~~

following cobgetopt I'd also suggest to rename the file

GitMensch · 2026-06-30T09:05:28Z

+AT_DATA([echo "-x @tempfile.txt" > tempfile.txt])
+AT_DATA([echo "-g --free" > otherfile.txt])


see above how AT_DATA is intended to be used (can still be single line)

GitMensch · 2026-06-30T09:05:53Z

+AT_SETUP(recursive @file with conflict)
+AT_KEYWORDS([cobc getopt])
+
+


2 before AT_SETUP one after AT_KEYWORDS

GitMensch · 2026-06-30T09:07:17Z

 	cb_config_text_column = 72;

 	/* Process command line arguments */
+	cob_expandargv(&argc, &argv);


is it useful to also add that to bin/cobcrun?

RamyGeorge commented May 3, 2026

View reviewed changes

Comment thread cobc/cobc.c Outdated

GitMensch requested changes May 5, 2026

View reviewed changes

Comment thread libcob/cobgetopt.c Outdated

Comment thread libcob/cobgetopt.c Outdated

Initial implementation for @file

0598be5

RamyGeorge force-pushed the initial-atfile branch from 032019f to 0598be5 Compare May 18, 2026 21:13

new implementation

2ffbb00

GitMensch requested changes May 19, 2026

View reviewed changes

RamyGeorge and others added 3 commits May 29, 2026 20:34

Fixing potenital mem leaks and some tweaks

d056176

Merge branch 'gitside-gnucobol-3.x' into initial-atfile

130c3f7

COB_EXPIMP for windowns linker

17f3707

GitMensch requested changes May 29, 2026

View reviewed changes

GitMensch reviewed Jun 2, 2026

View reviewed changes

Comment thread libcob/cobgetopt.c Outdated

RamyGeorge force-pushed the initial-atfile branch from 53ea68e to 8036fd2 Compare June 2, 2026 10:25

ISO C90 and updates

9dbd453

RamyGeorge force-pushed the initial-atfile branch 2 times, most recently from dd0e41a to 9dbd453 Compare June 2, 2026 16:03

recursive @file + conflicts handled

5337f3c

RamyGeorge and others added 3 commits June 29, 2026 22:58

argv.c and relevant changes

09eaebf

Merge branch 'gitside-gnucobol-3.x' into initial-atfile

176351a

argv.c and relevant changes

b3452c7

GitMensch requested changes Jun 30, 2026

View reviewed changes

		/* Test whether ARGV[optind] points to a non-option argument. */
		#define NONOPTION_P (argv[optind][0] != '-' \|\| argv[optind][1] == '\0')

		@@ -500,11 +498,11 @@ process_at_file(const char* argument_values,int* compile_mode,int* atfile_size){
		return NULL;
		}


		2026-05-29 Ramy George <ramygeorge19@gmail.com>

		* argv.c: extracted the argv.c file from GCC

		AT_DATA([echo "-x @tempfile.txt" > tempfile.txt])
		AT_DATA([echo "-g --free" > otherfile.txt])

		AT_SETUP(recursive @file with conflict)
		AT_KEYWORDS([cobc getopt])

Uh oh!

Conversation

RamyGeorge commented May 3, 2026

Summary

Motivation

Changes

Misc

Uh oh!

Uh oh!

GitMensch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

GitMensch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GitMensch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov-commenter commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov-commenter commented Jun 2, 2026 •

edited

Loading