Skip to content

[19.0][MIG] endpoint_auth_api_key: Migration to 19.0#130

Open
yankinmax wants to merge 23 commits intoOCA:19.0from
camptocamp:19.0-mig-endpoint_auth_api_key
Open

[19.0][MIG] endpoint_auth_api_key: Migration to 19.0#130
yankinmax wants to merge 23 commits intoOCA:19.0from
camptocamp:19.0-mig-endpoint_auth_api_key

Conversation

@yankinmax
Copy link
Copy Markdown

@yankinmax yankinmax commented Apr 1, 2026 •
edited
Loading

@yankinmax yankinmax force-pushed the 19.0-mig-endpoint_auth_api_key branch from 903ed7d to 035cd16 Compare April 1, 2026 13:23
@yankinmax yankinmax changed the title [MIG] endpoint_auth_api_key: Migration to 19.0 [19.0][MIG] endpoint_auth_api_key: Migration to 19.0 Apr 1, 2026
@yankinmax yankinmax force-pushed the 19.0-mig-endpoint_auth_api_key branch 9 times, most recently from 78f5dfa to 39f133f Compare April 1, 2026 15:08
@yankinmax
Copy link
Copy Markdown
Author

yankinmax commented Apr 1, 2026

I wonder what is happening with runboat tests:

INFO odoo odoo.service.server: Starting post tests 
INFO odoo odoo.addons.base.models.ir_qweb: Pregenerating assets bundles 
...
WARNING odoo odoo.addons.base.models.assetsbundle: Error: Undefined variable: "$black".
on line 1472:23 of stdin
>> // Color contrast variables used in the color-contrast function

   ----------------------^
This error occurred while compiling the bundle 'web.assets_frontend' containing:
...

INFO odoo odoo.service.server: 6 post-tests in 12.27s, 520 queries 
INFO odoo odoo.tests.stats: endpoint_auth_api_key: 10 tests 0.31s 262 queries 
INFO odoo odoo.tests.result: 0 failed, 0 error(s) of 6 tests when loading database 'odoo'

The module tests itself are green.

@ivantodorovich
Copy link
Copy Markdown

ivantodorovich commented Apr 1, 2026

I wonder what is happening with runboat tests:

INFO odoo odoo.service.server: Starting post tests 
INFO odoo odoo.addons.base.models.ir_qweb: Pregenerating assets bundles 
...
WARNING odoo odoo.addons.base.models.assetsbundle: Error: Undefined variable: "$black".
on line 1472:23 of stdin
>> // Color contrast variables used in the color-contrast function

   ----------------------^
This error occurred while compiling the bundle 'web.assets_frontend' containing:
...

INFO odoo odoo.service.server: 6 post-tests in 12.27s, 520 queries 
INFO odoo odoo.tests.stats: endpoint_auth_api_key: 10 tests 0.31s 262 queries 
INFO odoo odoo.tests.result: 0 failed, 0 error(s) of 6 tests when loading database 'odoo'

The module tests itself are green.

Not sure but other PRs in this branch are ok.
So the cause must be in the way we run tests here, or something.
Please find a way to fix otherwise we can't merge

@yankinmax yankinmax force-pushed the 19.0-mig-endpoint_auth_api_key branch 5 times, most recently from 2bbe633 to 84b8d7b Compare April 2, 2026 10:17
ivantodorovich
ivantodorovich approved these changes Apr 6, 2026
View reviewed changes
Copy link
Copy Markdown

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls list the depended PR in the description 🙏🏻

grindtildeath
grindtildeath approved these changes Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown

@grindtildeath grindtildeath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG 👍

Comment thread endpoint_auth_api_key/tests/common.py Outdated
simahawk and others added 13 commits April 29, 2026 14:11
@simahawk @yankinmax
endpoint_auth_api_key: adapt to new sync behavior
350fc4e
@yankinmax
[MIG] endpoint_auth_api_key: Migrate to version 16.0
e08c416
@mymage @yankinmax
Added translation using Weblate (Italian)
9dc360a
@simahawk @yankinmax
endpoint: add basic mixin view
fce1f78 
As the mixin can be inherited by many other models w/ their view
an isolated basic view is required to avoid pollution and breakage
of inherited views when extending the views of endpoint.endpoint.

In particular, this solves a conflict that came w/ OCA/web-api-contrib#1
@simahawk @yankinmax
endpoint_*: fix mixin view override
b78ac07 
Followup of OCA#56
The view must be registered for the mixin model otherwise it won't be taken into account.
I've probably left this change in a stashed version :(
@SilvioC2C @yankinmax
[IMP] endpoint_auth_api_key: pre-commit auto fixes
1c1ff6e
@SilvioC2C @yankinmax
[MIG] endpoint_auth_api_key: Migrate to version 17.0
91fdeb4
@xtanuiha @yankinmax
Added translation using Weblate (Chinese (Simplified) (zh_CN))
dfa0987
@xtanuiha @yankinmax
Translated using Weblate (Chinese (Simplified) (zh_CN))
446e2f9 
Currently translated at 100.0% (3 of 3 strings)

Translation: web-api-17.0/web-api-17.0-endpoint_auth_api_key
Translate-URL: https://translation.odoo-community.org/projects/web-api-17-0/web-api-17-0-endpoint_auth_api_key/zh_CN/
@simahawk @yankinmax
[IMP] endpoint_auth_api_key: pre-commit auto fixes
f2b43a9
@simahawk @yankinmax
endpoint_auth_api_key: migrate to v18
ab7b867
@simahawk @yankinmax
endpoint_auth_api_key: mute http logger to avoid warning
8a88a2b
@simahawk @yankinmax
endpoint_auth_api_key: adapt test to auth_api_key changes
b106e9f 
This commit changed the status to 401
OCA/server-auth@e4a9157
@yankinmax yankinmax force-pushed the 19.0-mig-endpoint_auth_api_key branch from 84b8d7b to 5591eaa Compare April 29, 2026 11:11
@OCA-git-bot OCA-git-bot added series:19.0 mod:endpoint_auth_api_key Module endpoint_auth_api_key labels Apr 29, 2026
@yankinmax
Copy link
Copy Markdown
Author

yankinmax commented Apr 29, 2026

Hello @OCA/board can you pls take a look and possibly trigger merge?

dreispt
dreispt reviewed Apr 29, 2026
View reviewed changes
Comment thread endpoint_auth_api_key/demo/endpoint_demo.xml Outdated
result = {"response": Response("ok")}
</field>
</record>
</odoo>
Copy link
Copy Markdown
Member

@dreispt dreispt Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the demo?

Copy link
Copy Markdown
Author

@yankinmax yankinmax Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've moved demo data to the tests.
But, probably we can have separate demo data and test data.
Let me check.

Copy link
Copy Markdown
Author

@yankinmax yankinmax Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello @dreispt , the PR is fixed, thank for the review

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Apr 29, 2026

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@yankinmax yankinmax force-pushed the 19.0-mig-endpoint_auth_api_key branch from ba0ab53 to 0e52150 Compare April 29, 2026 13:55
@yankinmax yankinmax force-pushed the 19.0-mig-endpoint_auth_api_key branch from 0e52150 to d01007d Compare April 29, 2026 14:03
@yankinmax
Copy link
Copy Markdown
Author

yankinmax commented Apr 30, 2026

Hello @dreispt can you pls take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dreispt dreispt dreispt left review comments

+2 more reviewers

@grindtildeath grindtildeath grindtildeath approved these changes

@ivantodorovich ivantodorovich ivantodorovich approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved mod:endpoint_auth_api_key Module endpoint_auth_api_key ready to merge series:19.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@yankinmax @ivantodorovich @OCA-git-bot @grindtildeath @dreispt @simahawk @sebalix @mymage @SilvioC2C @xtanuiha