Configure case-hack once in the NAR fuzzer - #16320
Merged
Merged
Conversation
JamieMagee
force-pushed
the
fuzz/harness-invariants
branch
from
August 18, 2026 04:39
eda296d to
39fad7f
Compare
Contributor
|
Actually, nix can't be built without assertions? At least we must not be built and we have a bit in libutil which fails the build if there NDEBUG |
Contributor
|
Specifically this Lines 15 to 17 in f6ac811 |
The case-hacked NAR fuzzer configures use-case-hack inside assert for every input, although this setup only needs to run once. Move the setup to a checked function-local static. Assisted-by: GitHub Copilot CLI (GPT-5.6 Sol)
JamieMagee
force-pushed
the
fuzz/harness-invariants
branch
from
August 18, 2026 22:53
39fad7f to
fa5e855
Compare
JamieMagee
changed the title
xokdvium
approved these changes
Aug 18, 2026
Member
|
BTW I would support giving the underlying function an overload takes an explicit parameter instead of using the setting. In addition to making this easier, that will help us slightly in our quest to get rid of global variables. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The case-hacked NAR fuzzer sets
use-case-hackinside anassertfor every input, even though the setting only needs to be applied once.Context
Move the setup to a checked function-local static. It runs once, and the harness traps if the setting cannot be applied.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.