fix(netlify): reverse proxy by download type - #1276
Merged
hsjobeki merged 1 commit intoJul 28, 2026
Merged
Conversation
Hydra no longer keeps build byproducts in a deterministic order, so the numeric `download/2` path drifts between `download/1` and `download/2`. This breaks the reverse-proxied Nix manual links whenever the ordering shifts. Reverse proxy by download type using `download-by-type/doc` instead of the numeric byproduct identifier. The download type resolves to the `doc` output regardless of byproduct ordering, which keeps the manual links stable. Fix NixOS/nix#16202. Signed-off-by: Leonard Sheng Sheng Lee <leonard.sheng.sheng.lee@gmail.com>
hsjobeki
approved these changes
Jul 28, 2026
Collaborator
|
Lets give it a try ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hydra no longer keeps build byproducts in a deterministic order, so the numeric
download/2path drifts betweendownload/1anddownload/2. This breaks the reverse-proxied Nix manual links whenever the ordering shifts.Reverse proxy by download type using
download-by-type/docinstead of the numeric byproduct identifier. The download type resolves to thedocoutput regardless of byproduct ordering, which keeps the manual links stable.Fix NixOS/nix#16202.