Skip to content

PIV: Add support for RSA 2048 private key import #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sosthene-nitrokey merged 5 commits into from
Mar 18, 2026
Merged

PIV: Add support for RSA 2048 private key import #721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7abdf61
Support python 3.14 and run updated formatting
sosthene-nitrokey Mar 5, 2026
48a60c0
PIV: Add support for RSA 2048 private key import
sosthene-nitrokey Jan 27, 2026
68f86a2
Remove duplication from review
sosthene-nitrokey Mar 5, 2026
3af416f
Separate import certificate to its own function
sosthene-nitrokey Mar 5, 2026
3ec247a
fixup! PIV: Add support for RSA 2048 private key import
sosthene-nitrokey Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion pynitrokey/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,4 @@

"""Python Library for Nitrokey devices."""


__all__ = ["client", "commands", "dfu", "enums", "exceptions", "helpers", "operations"]
6 changes: 3 additions & 3 deletions pynitrokey/cli/nethsm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1254,7 +1254,7 @@ def set_certificate(

This command requires authentication as a user with the Administrator
role."""
(api, key_id) = get_api_or_key_id(api, key_id)
api, key_id = get_api_or_key_id(api, key_id)
with connect(ctx) as nethsm:
with open(filename, "rb") as f:
if key_id:
Expand Down Expand Up @@ -1283,7 +1283,7 @@ def get_certificate(ctx: Context, api: bool, key_id: Optional[str]) -> None:
This command requires authentication as a user with the Administrator role.
The certificate for a key can also be queried by a user with the Operator
role."""
(api, key_id) = get_api_or_key_id(api, key_id)
api, key_id = get_api_or_key_id(api, key_id)
with connect(ctx) as nethsm:
if key_id:
cert = nethsm.get_key_certificate(key_id)
Expand Down Expand Up @@ -1350,7 +1350,7 @@ def csr(

This command requires authentication as a user with the Administrator
role."""
(api, key_id) = get_api_or_key_id(api, key_id)
api, key_id = get_api_or_key_id(api, key_id)
with connect(ctx) as nethsm:
if key_id:
csr = nethsm.key_csr(
Expand Down
Loading