Repository navigation
test(e2e): manage games through the rebuilt Games page (LAZ-1413) - #24550
Open
chnexusmods wants to merge 2 commits into
Open
chnexusmods wants to merge 2 commits into
chnexusmods wants to merge 2 commits into
Conversation
Scope "Manual add" to the "All supported games" section. In logged-in tests a store-installed game is also listed under "New games detected", whose tile leads with "Add game", so a page-wide lookup found the wrong tile. Adding a game activates it but no longer opens its workspace, since the spine now follows the open page (LAZ-880). Open the game from its tile under "Added games" before waiting for the Mods page. Split manageGame into addGameManually and openAddedGame, give the activation waits their own GAME_ACTIVATION timeout, and match the detected section by either of its titles. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
chnexusmods
marked this pull request as ready for review
October 15, 2026 13:05
chnexusmods
marked this pull request as draft
October 15, 2026 13:09
On the slower Linux runner the games list re-renders between the tile becoming visible and the scroll, and scrollIntoViewIfNeeded fails on the detached tile rather than retrying. hover already scrolls the tile into view and retries, so drop the separate scroll. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
chnexusmods
marked this pull request as ready for review
October 15, 2026 14:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the shared
manageGameE2E helper for the rebuilt Games page. A full local run onmasterhad 30 of its 32 failures in this helper, before any spec's own steps ran. That covers every spec that needs a managed game: Health Check, mods, Profiles, QA-103 and QA-106.Linear: LAZ-1413
Why it broke
Changes
selectors/games.ts:manualAddButtononly looks under "All supported games". NewopenButtonfor "Added games".detectedSectionmatches both "Games detected" and "New games detected".helpers/games.ts: after the dialog, open the game from its tile under "Added games", then wait for Mods.manageGameis split intoaddGameManuallyandopenAddedGame.helpers/timeouts.ts: newTimeouts.GAME_ACTIVATIONfor the activation waits, which aren't network-bound.Detection gives Vortex no game path (
VORTEX_E2E=1still disables discovery), so the tests still go through the "Game not discovered" dialog and manage the fake install. They never touch a real one.Testing
All runs local, headless,
CI=1:game-management.spec.tsandprofile.spec.ts: 5/5 passed before the helper split.Open question
Is staying on the Games page after adding a game the intended UX after LAZ-880? If not, the product change would make the extra Open step unnecessary.
🤖 Generated with Claude Code