Fix Vision Prediction, add vision off sound and separate sound channel for vision sounds. Also fix ghost pickup sound not playing on its own special channel - #2041
Open
AdamTadeusz wants to merge 6 commits into
Conversation
Contributor
Author
|
I added the tournament priority label since this also fixed the ghost pickup sound not playing on its own channel. If need be I can move this fix to a separate PR |
Contributor
Author
|
also this stops C_NEO_Player::PreDataUpdate returning early before calling the base class that does some important things so thats also important for the tourney |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
-----> EPILEPSY WARNING <------
Makes toggling the vision mode far smoother at high ping.
Recommend testing through the following:
bind mwheeldown +vision
test how quickly the vision mode can be triggered on a listen server and pay attention to the sound
then
net_fakelag 200
and do the same
also notice how individual inputs at high ping also don't cause the screen to flicker multiple times
Toolchain
Linked Issues