Skip to content

Add extended storage image formats - #102

Merged
SirLynix merged 2 commits into
NazaraEngine:mainfrom
ArthurVasseur:extended-storage-image-formats
Sep 15, 2026
Merged

SirLynix merged 2 commits into
NazaraEngine:mainfrom
ArthurVasseur:extended-storage-image-formats

Conversation

@ArthurVasseur

Copy link
Copy Markdown
Contributor
  • Register float and normalized storage image formats (r32f, rg32f, rg16f, r16f, r11f_g11f_b10f, rgba16, rgb10_a2, rg16, rg8, r16, r8 and their snorm variants)
  • GLSL: reject extended formats when targeting GLSL ES

Register float and normalized storage image formats:
r32f, rg32f, rg16f, r16f, r11fg11fb10f, rgba16,
rgb10a2, rg16, rg8, r16, r8, rgba16Snorm,
rg16Snorm, rg8Snorm, r16Snorm, r8Snorm
Older versions ignore EnumAsFlags<E>::AutoFlag, which breaks the build of
SpirvMemorySemantics and silently misinterprets non-auto flag enums.
@codecov

codecov Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 47.82609% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.36%. Comparing base (7dd436c) to head (086713f).

Files with missing lines Patch % Lines
src/NZSL/SpirV/SpirvConstantCache.cpp 25.00% 12 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
- Coverage   81.40%   81.36%   -0.05%     
==========================================
  Files         150      150              
  Lines       19168    19191      +23     
==========================================
+ Hits        15603    15614      +11     
- Misses       3565     3577      +12     
Files with missing lines Coverage Δ
src/NZSL/GlslWriter.cpp 84.33% <100.00%> (+0.01%) ⬆️
src/NZSL/SpirvWriter.cpp 88.43% <100.00%> (+0.08%) ⬆️
src/NZSL/SpirV/SpirvConstantCache.cpp 85.86% <25.00%> (-1.18%) ⬇️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dd436c...086713f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SirLynix

Copy link
Copy Markdown
Contributor

LGTM, thank you!

@SirLynix
SirLynix merged commit 33cc4e1 into NazaraEngine:main Sep 15, 2026
43 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants