Skip to content

Fuel cell sched warning#2196

Open
mjprilliman wants to merge 3 commits into
developfrom
fuel_cell_sched_warning
Open

Fuel cell sched warning#2196
mjprilliman wants to merge 3 commits into
developfrom
fuel_cell_sched_warning

Conversation

@mjprilliman
Copy link
Copy Markdown
Collaborator

@mjprilliman mjprilliman commented May 26, 2026

Description

-Add ssc warning for fuel cell dispatch periods outside of the 6 defined periods. Can occur when copying TOD schedules to battery, then copying fuel cell from battery dispatch.

To test:

-Open Fuelcell-PV-battery Single owner case
-Set Weekday TOD schedules to period 7
-Battery manual dispatch, click copy from TOD button
-Fuel cell manual dispatch, click copy from battery manual dispatch button
-Click simulate
-See error message.

Fixes #1969

Corresponding branches and PRs:

Same branch, PR for ssc, develop everywhere else

[ link any corresponding PRs in other repos, i.e. NREL/ssc#x ] NatLabRockies/ssc#1400

Unit Test Impact:

[ expected changes in unit tests or speed of tests? ]

[ expected changes in test_results files? ]

Checklist

  • requires help revision and I added that label
  • adds, removes, modifies, or deletes variables in existing compute modules
  • adds a new compute module
  • changes defaults
  • I've tagged this PR to a milestone

Reminders- this section can be deleted

[Checking for PySAM Incompatible API Changes]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files).

[When do the PySAM files need to be regenerated?]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files#when-do-the-pysam-files-need-to-be-regenerated-via-export_config)

Copy link
Copy Markdown
Collaborator

@cpaulgilman cpaulgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fuel Cell not throwing error for dispatch beyond max categories

2 participants