Fuel cell sched warning#2196
Open
mjprilliman wants to merge 3 commits into
Open
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
-Add ssc warning for fuel cell dispatch periods outside of the 6 defined periods. Can occur when copying TOD schedules to battery, then copying fuel cell from battery dispatch.
To test:
-Open Fuelcell-PV-battery Single owner case
-Set Weekday TOD schedules to period 7
-Battery manual dispatch, click copy from TOD button
-Fuel cell manual dispatch, click copy from battery manual dispatch button
-Click simulate
-See error message.
Fixes #1969
Corresponding branches and PRs:
Same branch, PR for ssc, develop everywhere else
[ link any corresponding PRs in other repos, i.e. NREL/ssc#x ] NatLabRockies/ssc#1400
Unit Test Impact:
[ expected changes in unit tests or speed of tests? ]
[ expected changes in test_results files? ]
Checklist
Reminders- this section can be deleted
[Checking for PySAM Incompatible API Changes]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files).
[When do the PySAM files need to be regenerated?]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files#when-do-the-pysam-files-need-to-be-regenerated-via-export_config)