Fix crash when opening floating settings (BadTokenException)#982
Merged
Nain57 merged 1 commit intoJul 15, 2026
Merged
Conversation
Disable OverlayDialog useWindowContext (breaks BottomSheetDialog.show on some devices) and restore adjustResize for soft keyboard.
Owner
|
Tested OK on emulator & OnePlus 10 Pro. |
Nain57
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WindowManager\$BadTokenException: Unable to add window -- token null is not valid.OverlayDialogenableduseWindowContext = truein 9fbe6af (IME toolbar on emulator). On some real devices,BottomSheetDialog.show()then fails with an invalid window token.OverlayDialog(keepBaseOverlay.useWindowContextavailable for cases that need it), and restoreSOFT_INPUT_ADJUST_RESIZE | SOFT_INPUT_STATE_HIDDENso soft-keyboard behavior does not regress.Changes
OverlayDialog.kt: dropuseWindowContext = true; addapplySoftInputMode()with adjustResize + hidden IME state.Notes
4.0.0-beta04; dropbox stack pointed atDialog.show→BadTokenException. The main floating menu (useWindowContext = false) was unaffected.