Skip to content

[no-ci] Clarify upstream CTK version control in versions.yml - #3338

Merged
mdboom merged 2 commits into
mainfrom
mdboom-patch-1
Nov 3, 2026
Merged

mdboom merged 2 commits into
mainfrom
mdboom-patch-1

Conversation

@mdboom

@mdboom mdboom commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Added comments to clarify version control for upstream CTK.

Adding, because my agent was confused by this when reviewing the #3314-#3322 stack.

Added comments to clarify version control for upstream CTK.
@mdboom
mdboom requested a review from rwgk November 3, 2026 14:54
@github-actions github-actions Bot added the CI/CD CI/CD infrastructure label Nov 3, 2026
@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Documentation
    • Clarified that the configured CUDA Toolkit version selects the upstream toolkit used for wheel builds, while the package release version is determined by Git tags.
    • The configured current and previous build versions remain unchanged, and the clarification does not change package behavior or build-version settings.

Comments in ci/versions.yml distinguish the upstream CTK version used for wheel builds from the package release version. The configured build versions remain unchanged.

Changes: CUDA version configuration

Layer / File(s) Summary
Clarify CUDA version fields
ci/versions.yml
Comments distinguish the CTK version used for wheel builds from package versions determined by Git tags. The configured build versions remain unchanged.

Possibly related issues

  • NVIDIA/cuda-python#3221: This issue concerns version synchronization in ci/versions.yml. This pull request clarifies version roles but does not add synchronization checks.

Possibly related PRs

Change: Other

Merge Risk: Minimal · up to f7dce

The clarification does not change configured build versions, and the whitespace issue is fixed. The configuration change is ready to merge, subject to outstanding PR metadata requirements.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between af94ca4 and f7dce18.

Files selected for processing: 1
  • ci/versions.yml
Files skipped from review as they are similar to previous changes: 1
  • ci/versions.yml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 10 remain after this review.

Comment thread ci/versions.yml Resolved
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@mdboom mdboom self-assigned this Nov 3, 2026
@mdboom mdboom added this to the cuda.core next milestone Nov 3, 2026
@mdboom
mdboom merged commit 54e0f2c into main Nov 3, 2026
31 of 32 checks passed
@mdboom
mdboom deleted the mdboom-patch-1 branch November 3, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD CI/CD infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants