Repository navigation
perf(docker): slow steady-state supervisor healthcheck - #4802
Open
lunarwhite wants to merge 1 commit into
Open
lunarwhite wants to merge 1 commit into
lunarwhite wants to merge 1 commit into
Conversation
Signed-off-by: Yuedong Wu <dwcn22@outlook.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep the Docker supervisor healthcheck's 250 ms
start_intervalfor fast readiness detection and raise the steady-stateintervalfrom 250 ms to 30 s, as proposed in the triage.Related Issue
Closes #4729
Changes
SUPERVISOR_HEALTH_INTERVAL_NSto 30 s. Timeout, retries, and the 60 s start period are unchanged.HealthConfigintodocker_supervisor_healthcheck()and pin all three timing values in a unit test.Readycomes from the supervisor session and is unaffected.Testing
Additionally, one idle sandbox, Docker 29.7.2 on WSL2, gateway built from
mainvs this branch:mainsandbox start(3 runs)Ready/ to DockerhealthyChecklist