Repository navigation
feat(kubernetes): deploy shared supervisor mode - #4695
Merged
Merged
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
🌿 Preview your docs: https://nvidia-preview-pr-4695.docs.buildwithfern.com/openshell |
drew
force-pushed
the
feat/4694-experimental-supervisor-topology/drew
branch
from
October 18, 2026 23:15
40647e6 to
856ad8a
Compare
drew
changed the base branch from
main
to
feat/4652-sandbox-initiated-control/drew
October 18, 2026 23:15
drew
added this pull request to stack #4698
October 18, 2026 23:15
7 tasks done
drew
force-pushed
the
feat/4694-experimental-supervisor-topology/drew
branch
from
October 20, 2026 16:24
856ad8a to
d5fc1df
Compare
TaylorMutch
reviewed
Oct 20, 2026
Base automatically changed from
feat/4652-sandbox-initiated-control/drew
to
main
October 20, 2026 18:39
drew
force-pushed
the
feat/4694-experimental-supervisor-topology/drew
branch
from
October 20, 2026 18:39
121142e to
702a7fa
Compare
TaylorMutch
previously approved these changes
Oct 20, 2026
drew
marked this pull request as ready for review
October 20, 2026 22:00
drew
force-pushed
the
feat/4694-experimental-supervisor-topology/drew
branch
from
October 20, 2026 22:10
702a7fa to
7438e4e
Compare
drew
changed the title
drew
changed the title
|
Label |
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
… section Signed-off-by: Drew Newberry <anewberry@nvidia.com>
experimental-bootstrap now takes --health-port instead of a Unix health socket. It binds the dedicated supervisor's wildcard readiness listener, reachable at the Pod IP, and accepts and closes connections while the process runs. The chart probes the named container port health (5502) with native kubelet tcpSocket checks and drops the health-only emptyDir. No filesystem state remains to clean up after an unclean exit. Dedicated supervisors keep --health-socket-path and health --socket. Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Remove the experimental supervisor topology additions from the published gateway configuration page and the public debug-openshell-cluster skill. Public documentation will be added once the experimental stack settles. Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Rename the shared-mode host module from experimental to shared to match the --mode=shared flag. No behavior changes. Signed-off-by: Drew Newberry <anewberry@nvidia.com>
…r topology Rename the Helm template to supervisor.yaml, its Kubernetes names and labels to the -supervisor suffix and supervisor component, and the driver setting to supervisor_topology. The setting remains opt-in and workspace remains reserved. Signed-off-by: Drew Newberry <anewberry@nvidia.com>
drew
force-pushed
the
feat/4694-experimental-supervisor-topology/drew
branch
from
October 21, 2026 01:05
62837d2 to
90537ef
Compare
TaylorMutch
approved these changes
Oct 21, 2026
Collaborator
Author
|
/ok to test 90537ef |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting
[openshell.drivers.kubernetes].supervisor_topology = "gateway"makes Helm deploy one shared-supervisor placeholder in the gateway namespace. Sandboxes continue using dedicated supervisors in this plumbing PR.The Deployment runs
openshell-supervisor --mode=shared --gateway-endpoint <gateway-url> --address 0.0.0.0:5501. The address is a single TCP listener used by both Kubernetes health probes; the gateway endpoint is reserved for the supervisor's future outbound connection. The placeholder accepts and closes connections, logs its startup, and shuts down on SIGTERM/SIGINT. Session control and sandbox hosting arrive in later PRs.The setting is omitted by default.
workspaceis reserved and rejected. The separate, single-replica Deployment applies to shared, managed, and operator workspace namespace modes and uses the configured supervisor image under a restricted nonroot security context. Public documentation is deferred; crate and contributor guidance describe this stage.Validation: scoped supervisor build/Clippy, formatting and documentation lint, six focused Helm tests, native CLI/TCP/shutdown checks, and a Kubernetes rollout/restart smoke test with TCP probes on port 5501 passed. The default dedicated entry point remains unchanged.
Closes #4694