Skip to content

test(tmachine): support package-installed Podman driver suites - #4107

Merged
elezar merged 2 commits into
mainfrom
codex/driver-installation-tests
Oct 5, 2026
Merged

elezar merged 2 commits into
mainfrom
codex/driver-installation-tests

Conversation

@elezar

@elezar elezar commented Oct 2, 2026 •

Copy link
Copy Markdown
Member

Summary

Podman driver suites currently assume the binary installer's CLI path, HTTP registration, configuration file, and system service. Reuse the installed gateway's context so the same suites preserve HTTPS client credentials and target the correct configuration and service when run against native packages. Switch the three Fedora driver-specific branch lanes to RPMs.

Related Issue

No issue required: scoped test-harness maintenance fixes installer assumptions in existing qualification suites; product behavior and public APIs are unchanged. Builds on the package qualification work merged in #4025 and #4056.

Changes

  • Publish non-secret gateway metadata from the shared client registration role; resolve the installed CLI from PATH and retain the existing registration and credentials.
  • Apply namespace fixtures to the active gateway config's Podman table, restart the matching system/user service, and check authenticated healthy readiness.
  • Collect journals for the matching service and UID, including root's packaged user service.
  • Preserve default, auto, keep-id, and explicit private UID/GID mapping coverage in rootful and rootless modes. Resolve the rootless E2E socket/UID and use the installed gateway's network name.
  • Document supported environments and cache behavior.

Testing

  • mise run pre-commit passes (the unrelated, untracked pr-issue-summary.md was temporarily kept outside check inputs).
  • Ansible syntax checks for the binary, DEB, RPM, and all Podman suite entry points; workflow actionlint and matrix validation; git diff --check.
  • Representative tmachine guest checks: actual Ubuntu/Docker DEB installation, HTTPS registration, metadata loading, packaged user-service restart, authenticated readiness, and journal collection.
  • Fedora binary installer fixture checks in rootful and rootless Podman: default, auto, keep-id, and explicit private mappings, healthy gateway readiness after config changes, and system-service journal collection. Candidate binaries were extracted from the existing DEB artifact and supplied explicitly to the normal binary installer in a temporary validation config.
  • Real RPM installation and full driver-podman/e2e-podman nextest archive runs: candidate RPMs and those archives were absent locally. The fixture checks above capture direct Podman mappings and verify gateway configuration loading, but do not run the missing archive's OpenShell-versus-reference comparisons.

Full local CI was attempted. After using the existing Nix Z3 library via LIBRARY_PATH, mise run ci reached the Rust tests and stopped in five existing openshell-driver-vm tests because mke2fs/mkfs.ext4 (e2fsprogs) are unavailable on this host. Full CI is not reported as passing.

Checklist

  • Follows Conventional Commits.
  • Commits are signed off (DCO).
  • Test/CI documentation updated; crate architecture documentation is not applicable.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Oct 2, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown

@elezar
elezar marked this pull request as ready for review October 2, 2026 08:56
@elezar
elezar requested review from a team, derekwaynecarr, mrunalp and sjenning as code owners October 2, 2026 08:56
Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar

elezar commented Oct 5, 2026

Copy link
Copy Markdown
Member Author

/ok-to-test 0ab64f3

@SDAChess

SDAChess commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

Closes #3454

@elezar
elezar added this pull request to the merge queue Oct 5, 2026
Merged via the queue into main with commit 8990656 Oct 5, 2026
93 checks passed
@elezar
elezar deleted the codex/driver-installation-tests branch October 5, 2026 14:07
@drew drew added the test:e2e Requires end-to-end coverage label Oct 5, 2026
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown

Label test:e2e applied, but pull-request/4107 does not exist yet. A maintainer needs to comment /ok to test 0ab64f359c42d7e97e018599137c62d145e1eaaf to mirror this PR. Once the mirror exists, re-apply the label or re-run Branch E2E Checks from the Actions tab.

benoitf pushed a commit to benoitf/OpenShell that referenced this pull request Oct 5, 2026
…IA#4206)

Revert PR NVIDIA#4107 and restore binary installers for the Podman driver qualification lanes.

This reverts commit 8990656.

Signed-off-by: Simon Scatton <sscatton@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:e2e Requires end-to-end coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants