Hua work common#107
Merged
Merged
Conversation
When hostname is supplied, the command is invoked via ``ssh <hostname> <cmd>``. The leading command name is first resolved to its absolute path through ``command_path`` so the remote shell does not have to rely on its own PATH to find the executable. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Adds a dedicated self.CMDPATHS cache so repeated calls for the same
bare command name skip the shutil.which() filesystem walk. Also
replaces the re.search() path-separator check with plain ``in`` tests
and the split(' ', 1) call with a single find()+slice. Repeat
lookups are roughly 200x faster (~140 us vs ~28 ms per 1000 calls).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates command-resolution behavior in the class-based common utilities, adds optional remote execution support for dynamic option lookup, and bumps the package version to 2.1.10.
Changes:
- Adds cached command path resolution in
PgLOG.command_path. - Adds an optional
hostnameargument toPgCMD.get_dynamic_options. - Updates package/version references in metadata and README.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/rda_python_common/pg_log.py |
Adds CMDPATHS cache and uses it in command_path. |
src/rda_python_common/pg_cmd.py |
Adds optional SSH wrapping for dynamic option commands. |
src/rda_python_common/__init__.py |
Bumps exported package version. |
README.md |
Updates documented current version. |
pyproject.toml |
Bumps package distribution version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| """ | ||
| if oindex: cmd += " {}".format(oindex) | ||
| if otype: cmd += ' ' + otype | ||
| if hostname: cmd = "ssh {} {}".format(hostname, self.command_path(cmd)) |
| return pgctl | ||
|
|
||
| def get_dynamic_options(self, cmd, oindex, otype): | ||
| def get_dynamic_options(self, cmd, oindex, otype, hostname=None): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.