Fix Laguna Evalution runtime configuration - #2961
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
random_seedas an Evalution engine option and normalize it to Evalution's canonicalseedseedandrandom_seed, preventingrandom_seedfrom leaking intoLagunaForCausalLM.__init__Root cause
The Evalution adapter recognized
seedbut notrandom_seed, so the latter remained inModel.model_kwargsand was forwarded throughGPTQModel.load()to the Hugging Face model constructor. Separately, Laguna S 2.1's evaluation config used a plain prompt even though its reasoning mode is selected by the chat template and declared asdefault_chat_template_kwargs={"enable_thinking": true}ingeneration_config.json.This change keeps
seedcanonical, acceptsrandom_seedonly as a backwards-compatible engine alias, and enables chat-template evaluation specifically for Laguna S 2.1.Validation
CUDA_VISIBLE_DEVICES=2,3 PYTHON_GIL=0 pytest -q tests/test_eval_loader_args.py tests/test_model_test_helpers.py tests/test_laguna_support.py— 18 passedruff checkon all changed files — passedgit diff --check— passed38, empty model kwargs, EOS[2, 24],</assistant>token[24], and prompt suffix<assistant><think>Companion Evalution fix: ModelCloud/Evalution#128