fix: use transfer amount enforcers for fixed allowances#282
Draft
mj-kiwi wants to merge 2 commits into
Draft
Conversation
…er amount terms and add timestamp handling
jeffsmale90
reviewed
Jul 23, 2026
Comment on lines
92
to
94
| if (getByteLength(terms) !== EXPECTED_TERMS_BYTELENGTH) { | ||
| throw new Error('Invalid erc20-token-allowance terms: expected 116 bytes'); | ||
| throw new Error('Invalid erc20-token-allowance terms: expected 52 bytes'); | ||
| } |
Collaborator
There was a problem hiding this comment.
We should use the decodeERC20TransferAmountTerms function from @metamask/delegation-core instead of bespoke decoding (we had bespoke decoding because the duration is invalid - UINT256_MAX, and it decodes to number type), which includes explicit validation of the terms length
…token allowance configurations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Provide a brief description of the changes in this PR
🔄 What Changed?
List the specific changes made:
🚀 Why?
Explain the motivation behind these changes:
🧪 How to Test?
Describe how to test these changes:
List any breaking changes:
📋 Checklist
Check off completed items:
🔗 Related Issues
Link to related issues:
Closes #
Related to #
📚 Additional Notes
Any additional information, concerns, or context: