Repository navigation
chore: bump @metamask/device-mcp to ^0.5.0 - #58
Draft
cryptotavares wants to merge 1 commit into
Draft
cryptotavares wants to merge 1 commit into
cryptotavares wants to merge 1 commit into
Conversation
0.5.0 sends an Origin header on Hermes CDP WebSocket connections (derived from the target WebSocket URL). Without it, Metro rejects the debugger connection with "origin 'undefined'". No API changes between 0.4.2 and 0.5.0, so this is a version bump only.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
cryptotavares
added this pull request to stack #63
October 23, 2026 20:59
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Core pins
@metamask/device-mcp ^0.4.2(package.json:65). 0.4.2 opens the Hermes debugger WebSocket without anOriginheader, and Metro rejects that withConnection from DevTools failed to be established for origin 'undefined'. device-mcp 0.5.0 sends anOriginderived from the target WebSocket URL (ws:→http:, loopback →127.0.0.1, port kept). It also accepts an override (RunHermesCdpInput.origin/HERMES_CDP_ORIGIN).@metamask/device-mcpto^0.5.0(lockfile resolves0.5.0;yarn dedupefinds nothing to change).Part of the mm CLI v2 effort: ticket
P1-02(Phase 1).Stacked on #57 (review that first).
Breaking changes
None.
Consumer impact
test/e2e/playwright/llm-workflow/tests/llm-workflow/@metamask/device-mcpto^0.5.0. Also, the iOS JS liveness probe (ios/hermes-health.tsverifyJsLiveness) opened its own debugger WebSocket with noOrigin, so Metro rejected it on every iOS launch and launch fell back to target-presence-only health. It now sends the same Origin as device-mcp.cryptotavares/mm-cli-v2-mobilea4ee5a0de18Proof
Tested with a yalc build of this branch (core
0.12.0+923eaf77, device-mcp 0.5.0 from npm) in the Extension (e2e test build 13.56.0, headless) and Mobile (dev client 8.19.0, iOS sim + Android emulator, Metro on 8085).yarn test/yarn lintwith npm 0.5.0mm cdp Runtime.evaluate 1+1"value": 2"value": 2(4 calls)mm cdp Runtime.evaluate 1+1"value": 2"value": 2(2 calls)origin 'undefined'errors frommm cdp(iOS + Android)mm launch(consumer liveness probe)The device-mcp path was isolated in a separate iOS session: the launch window logged 1 error (consumer probe), and 3 cdp calls logged 0.
Transcripts
Unit tests