Repository navigation
fix: flaky test due to clock assertion - #53
Merged
Merged
Conversation
7 tasks
cryptotavares
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We have a flaky tests which has failed multiple times in ci with this error:
https://github.com/MetaMask/client-mcp-core/actions/runs/38712747231/job/116348149969
The "retries up to deadline and returns 'unknown'" test advances fake timers by 500 ms, then asserts that real elapsed time was ≤ 600 ms. That real time includes the HTTP round trip, so it fails on slow CI runners. The fake-timer deadline and the toHaveBeenCalledTimes(6) check already verify the behaviour, so the wall-clock check is removed.