Fix #1342: [Bug] v2.0.10 依赖冲突: numpy/scipy/chonkie 版本不兼容#1971
Open
Memtensor-AI wants to merge 1 commit into
Open
Fix #1342: [Bug] v2.0.10 依赖冲突: numpy/scipy/chonkie 版本不兼容#1971Memtensor-AI wants to merge 1 commit into
Memtensor-AI wants to merge 1 commit into
Conversation
…bility The [tool.poetry.group.eval] block declared `scipy = "^1.10.1"`, but scipy 1.10.x pins `numpy<1.27.0` while chonkie>=1.6 requires `numpy>=2.0.0`. The two constraints cannot be jointly satisfied, so users hitting both packages saw the `ImportError: numpy.core.multiarray failed to import` reported in #1342. scipy 1.13.0 is the first release that supports numpy 2.x, so this commit: - Bumps the eval-group scipy floor `^1.10.1` -> `^1.13.0`. - Adds an explanatory comment near the chonkie entry in `mem-reader` extras so future readers see the numpy 2.x implication. scipy is only imported by `evaluation/scripts/{longmemeval,locomo}_eval.py`; no `src/memos/` code path is affected. The committed `poetry.lock` already resolves scipy to 1.15.3 / 1.16.0 (numpy 2.2.6 / 2.3.1), all of which satisfy the new floor, so no re-lock is needed. Fixes #1342
Collaborator
Author
❌ Automated Test Results: FAILED
Failed tests:
Error detailsBranch: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
Fixes #1342: numpy / scipy / chonkie version conflict.
Root cause.
pyproject.toml [tool.poetry.group.eval]declaredscipy = "^1.10.1". scipy 1.10.x pinsnumpy<1.27.0(verified via the PyPI JSON metadata), whilechonkie>=1.6.0requiresnumpy>=2.0.0. The two constraints are jointly unsatisfiable, so any environment that ends up with both packages (the user's reproduction installs chonkie on top of an apt-installed scipy 1.10.x) raisesImportError: numpy.core.multiarray failed to import.Fix. Bumped the eval-group scipy floor from
^1.10.1to^1.13.0(scipy 1.13 is the first release supporting numpy 2.x) and added two explanatory comments — one near the bumped floor and one above thechonkieentry in themem-readerextras — so future readers see the numpy 2.x implication.Scope.
scipyis only imported byevaluation/scripts/longmemeval/lme_eval.pyandevaluation/scripts/locomo/locomo_eval.py; nothing undersrc/memos/references it (grep clean). The change is therefore constraint-only, no source code path is affected.Verification.
ruff check pyproject.toml→ "All checks passed!";ruff format --check pyproject.toml→ no diff;pytest tests/chunkers/→ 3 passed in 4.26s; TOML reparsed viatomli.loadreportseval scipy= ^1.13.0. The committedpoetry.lockalready resolves scipy to 1.15.3 / 1.16.0 and numpy to 2.2.6 / 2.3.1, all of which satisfy the new^1.13.0floor, so a re-lock would be a no-op and is deferred to the pre-commitpoetry-lockhook on the maintainer's machine.Related Issue (Required): Fixes #1342
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Automated tests are pending.
Checklist
@MatthewZhuang, @CarltonXiang, @syzsunshine219, @World-controller please review this PR.
Reviewer Checklist