Repository navigation
fix(logging,config): logging and config robustness (review batch 4) - #420
Merged
Merged
Conversation
The branch is main plus exactly the combined test build's state after this PR (conflicts with the PRs merged before it resolved as tested), version 0.24.13. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011zPmivSAQeivGUdBjTsaMu
Maxaubert
force-pushed
the
fix/419-logging-config-robustness
branch
from
October 10, 2026 02:28
4cc0f83 to
0de5e7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #419. Batch 4 of the 2026-10-09 review, Low section.
Fixed
Config.IniWriteLock(named mutex) andUpdateIniKeysin profiles_io.h; Settings setConfig, the flyout flush and the engine pick use them.clampdmaps NaN to the lower bound, trackGlideMs and txMaxStepPct are clamped.profileName.js.ResolveIniPathis cached likeResolveLogDir.modelspecial case dropped from SessionDiffers (the core default is hybrid).InitTrayBlockresets the pacing ring (and the stale menuOpen flag).Skipped / partial
Tests
build.bat test:[doctest] test cases: 604 | 604 passed | 0 failed,assertions: 97639 | 97639 passed | 0 failedbuild.batandbuild.bat config: both exit 0 (Wind.exe, WindTray.exe, WindConfig.exe built).No version bump: bumped at merge time.
🤖 Generated with Claude Code
https://claude.ai/code/session_011zPmivSAQeivGUdBjTsaMu