Repository navigation
No compiler notices: flatxml at 2a2650f, dead code removed, shadowing names renamed - #18
Merged
Merged
Conversation
… names renamed Building the command or any test printed notices: flatxml's unused union_of (gone at 5da7bdc), short_name_of and all_skipped (unused), read_options' unused parameter, from_dir in relocate shadowing modelfile's function, a test's src helper shadowed by pathindex, an unused import and two needless mut copies in tests. builtin_files is read by the test alone, so gen_builtin.vsh now writes it into builtin_test.v rather than the library. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MartenH
changed the title
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building
cmd/arxmodelor any test printed notices (and a program vendoring arxmodel printed them too):union_of— vendored flatxml 2a2650f (main, past #40 which drops it)short_name_ofandall_skipped— unused, removed;read_optionstook a parameter it never readfrom_dirinrelocateshadowed modelfile's function — renamedsrc_dir/dst_dirbuiltin_filesis read only by the test, sogen_builtin.vshnow writes it intobuiltin_test.v(generated withbuiltin.v) instead of the librarysrchelper renamedsource_of(shadowed by a library local), an unusedflatxml.xsdimport, two needlessmutcopiesv -checkovercmd/*and every test prints nothing on the pinned V (e7bb21c) and on master 0535623.v test .(19/19) and the four CLI script tests pass.🤖 Generated with Claude Code