Conversation
Why these changes are being introduced: UXWS has requested for journal records with Browzine links should also include a 'Full-text options' button that links to the full record. Relevant ticket(s): - [USE-614](https://mitlibraries.atlassian.net/browse/USE-614) How this addresses that need: This adds the 'Full-text options' link. Side effects of this change: None.
Coverage Report for CI Build 27723082754Coverage decreased (-0.05%) to 98.35%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
There was a problem hiding this comment.
Pull request overview
This PR adds a new “Full-text options” link to the ThirdIron/BrowZine fulfillment UI so that journal results with BrowZine data can also offer a path back to the source “full record” page.
Changes:
- Pass a
full_record_urlthrough the BrowZine content-loader request so the BrowZine partial can render a “Full-text options” link. - Adjust BrowZine/LibKey link CSS class usage (tests now assert
.libkey-linkrather than.buttonin some cases). - Add a controller test covering the BrowZine route when
full_record_urlis provided.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
app/controllers/thirdiron_controller.rb |
Plumbs full_record_url from request params into the BrowZine view. |
app/views/search/_result_primo.html.erb |
Extracts the Primo “full record” link and passes it toward the BrowZine trigger. |
app/views/search/_trigger_browzine.html.erb |
Appends full_record_url to the BrowZine loader URL. |
app/views/thirdiron/browzine.html.erb |
Renders the new “Full-text options” link alongside the BrowZine link. |
app/views/thirdiron/libkey.html.erb |
Adjusts BrowZine link CSS classes used in the LibKey-rendered HTML. |
test/controllers/thirdiron_controller_test.rb |
Updates selectors for LibKey HTML and adds a BrowZine + full_record_url test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2 new issues
|
|
|
||
| parsed.to_s | ||
| rescue URI::InvalidURIError | ||
| nil |
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
app/views/search/_trigger_browzine.html.erb:9
data-content-loader-url-valueis currently unquoted. With the newfull_record_urlquery param this attribute value now includes&and multiple=characters, which can lead to invalid HTML and fragile parsing. Quoting the attribute value makes the markup valid and robust.
<% data_url = "/browzine?#{query_params.to_query}" %>
<span class="libkey-container"
data-controller="content-loader"
data-content-loader-url-value=<%= data_url %>>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why these changes are being introduced:
UXWS has requested for journal records with
Browzine links should also include a 'Full-text
options' button that links to the full record.
Relevant ticket(s):
How this addresses that need:
This adds the 'Full-text options' link.
Side effects of this change:
None.
Developer
Accessibility
New ENV
Approval beyond code review
Additional context needed to review
E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.
Code Reviewer
Code
added technical debt.
Documentation
(not just this pull request message).
Testing