Display availability statements when relevant#408
Open
matt-bernhardt wants to merge 5 commits into
Open
Conversation
Coverage Report for CI Build 27716939663Coverage increased (+0.01%) to 98.415%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
❌ 2 blocking issues (3 total)
|
| # valid_alma_id? method | ||
| test 'valid_alma_id? returns true for valid inputs' do | ||
| needles = [ | ||
| 990002935920106761, |
This will be loaded via Stimulus when needed in a subsequent commit. Alma SRU controller tests
This still needs to be filtered, most likely (tho the AlmaSru model will also do its own filtering) Squash
This involves adding lazy-loading support to the content loader controller, which may be a feature that other async calls would benefit from.
This allows for better DX throughout the UI.
- Also adds additional filter on UI invoking this path, leveraging new validation method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This integrates the recently-added
AlmaSrumodel with the UI, restoring the availability statements for users to see. This involves:/almasruwhich invokes the lookup methodIn service of these goals, a few other changes get introduced:
data-content-loader-lazy-loading-value=""to the tag which calls the controller.valid_alma_id?()method. The UI leverages this to make sure we only ask for this lookup when the ID seems relevant (there's no way to know from just an identifier whether a record will actually have an availability block - but we can tell when a record comes from Alma).Side effects:
AlmaSrugets renamed from.alma_sru_enabled?to just.enabled?Developer
Accessibility
New ENV
Approval beyond code review
Additional context needed to review
Do searches in the review app (or when running locally), and watch the network traffic in your dev tools. You should see lazy-loading happening, and you should only see this happening for records with Alma docIDs. This should happen across tabs.
Code Reviewer
Code
added technical debt.
Documentation
(not just this pull request message).
Testing