Fix rotation and ST time smoothing state on restart - #1059
Merged
Conversation
Member
Author
|
the double_bh fpe failure on my machine is a known issue related to fpe checks complaining about the nans in the roche tables. Otherwise, the tests are passing and the fpe checks passed on BOSE. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Photo restarts could use an uninitialized w_div_w_crit_roche while reconstructing i_rot. They could also discard mstar_old and the saved ST coefficients before the first post-restart remeshing event.
The solution is to Initialize the rotation geometry before reconstructing i_rot, save mstar_old in photos, and preserve the ST time smoothing inputs through the first new_generation. Bump the star photo version to 19. Part of the solution uses the photo restart fixes to ST taken from https://github.com/MESAHub/mesa/pull/553/changes (originally found by @rjfarmer)
The three affected star test cases pass their restart and checksum checks with FPE checks enabled:
The ST restart state was also verified with double_bh through a model-700 restart, but it also revealed a second fpe issue in the binary Roche potential routines. That problem is specific to nans and -infinity values inside the Roche potential tables and deserves its own separate pr.